Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show uploaded files in vacancy details page #123

Merged
merged 6 commits into from
Dec 6, 2019
Merged

Show uploaded files in vacancy details page #123

merged 6 commits into from
Dec 6, 2019

Conversation

2-u
Copy link
Contributor

@2-u 2-u commented Dec 6, 2019

Update on things we discussed in last code review.
Generate download URL on the fly based on the value stored in:

  • this.exercise.uploadedJobDescriptionTemplate
  • this.exercise. uploadedTermsAndConditionsTemplate

2-u added 3 commits December 3, 2019 22:49
@2-u
show uploaded items in vacancy details page
2b78e7d 
Show download links in the Vacancy detail page for:
- Job Description
- Terms and Conditions
@2-u
set uploaded templates type only
81ed641
@2-u
fix vacancy download uploaded files
e60d7fd
@2-u 2-u requested a review from warrensearle December 6, 2019 07:01
warrensearle
warrensearle approved these changes Dec 6, 2019
View reviewed changes
Copy link
Member

@warrensearle warrensearle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@2-u 2-u merged commit f55f438 into master Dec 6, 2019
@2-u 2-u deleted the show-uploaded-files-in-vacancy-details-page branch December 6, 2019 10:28
warrensearle pushed a commit that referenced this pull request Jan 26, 2020
Show uploaded files in vacancy details page (#123)
4f90bad 
* show uploaded items in vacancy details page

Show download links in the Vacancy detail page for:
- Job Description
- Terms and Conditions

* set uploaded templates type only

* fix vacancy download uploaded files

* ran npm audit fix
@tomlovesgithub tomlovesgithub mentioned this pull request Apr 19, 2021
Merged
@lloback lloback mentioned this pull request Apr 20, 2021
Merged
@warrensearle warrensearle mentioned this pull request May 6, 2021
Closed
This was referenced May 14, 2021
Merged
Merged
Merged
Merged
This was referenced May 21, 2021
Merged
Merged
@warrensearle warrensearle mentioned this pull request May 24, 2021
Closed
3 tasks
This was referenced May 25, 2021
Merged
Merged
@mbrookeswebdev mbrookeswebdev mentioned this pull request May 28, 2021
Merged
@HalcyonJAC HalcyonJAC mentioned this pull request Jun 2, 2021
Merged
3 tasks
@warrensearle warrensearle mentioned this pull request Jun 4, 2021
Merged
@HalcyonJAC HalcyonJAC mentioned this pull request Jun 10, 2021
Merged
3 tasks
This was referenced Jun 14, 2021
Closed
Closed
Merged
This was referenced Jun 20, 2022
Merged
Merged
@HalcyonJAC HalcyonJAC mentioned this pull request Jul 6, 2022
Merged
@tomlovesgithub tomlovesgithub mentioned this pull request Jul 8, 2022
Merged
@HalcyonJAC HalcyonJAC mentioned this pull request Jul 14, 2022
Merged
This was referenced Jul 25, 2022
Merged
Merged
Merged
Merged
Merged
@tomlovesgithub tomlovesgithub mentioned this pull request Aug 2, 2022
Merged
@HalcyonJAC HalcyonJAC mentioned this pull request Sep 6, 2022
Merged
@tomlovesgithub tomlovesgithub mentioned this pull request Sep 15, 2022
Merged
@lloback lloback mentioned this pull request Nov 4, 2022
Closed
4 tasks
This was referenced Dec 1, 2022
Merged
Merged
Merged
@warrensearle warrensearle mentioned this pull request Feb 2, 2023
Merged
17 tasks
@drieJAC drieJAC mentioned this pull request Mar 16, 2023
Merged
@HalcyonJAC HalcyonJAC mentioned this pull request Dec 14, 2023
Merged
@KoWeiJAC KoWeiJAC mentioned this pull request Jan 19, 2024
Merged
@KoWeiJAC KoWeiJAC mentioned this pull request Feb 5, 2024
Merged
This was referenced Feb 7, 2024
Merged
Merged
@KoWeiJAC KoWeiJAC mentioned this pull request Feb 28, 2024
Merged
@tomlovesgithub tomlovesgithub mentioned this pull request Mar 5, 2024
Merged
@KoWeiJAC KoWeiJAC mentioned this pull request Apr 15, 2024
Merged
@KoWeiJAC KoWeiJAC mentioned this pull request Jun 24, 2024
Merged
@HalcyonJAC HalcyonJAC mentioned this pull request Jul 16, 2024
Merged
@tomlovesgithub tomlovesgithub mentioned this pull request Nov 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warrensearle warrensearle warrensearle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@2-u @warrensearle