Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin/1725 Late application #1788

Closed
wants to merge 5 commits into from
Closed

Conversation

lloback
Copy link
Contributor

@lloback lloback commented Nov 4, 2022

Author checklist

  • Include primary ticket number in title - e.g. "Show uploaded files in vacancy details page #123 New styling for widget" - and any additional tickets in description
  • Fill in the details below and delete as appropriate
  • Be proactive in getting your work approved 💪
  • Delete this checklist when you've completed it

What's included?

Describe the changes included in this pull request and highlight dependencies with other repos/tickets

Who should test?

✅ Product owner
✅ Developers
✅ UTG

How to test?

Describe the steps required to test & verify this change

Risk - how likely is this to impact other areas?

🟢 No risk - this is a self-contained piece of work
🟠 Medium risk - this does change code that is shared with other areas
🔴 High risk - this includes a lot of changes to shared code

Additional context

Include screen grabs, video demo, notes etc.

Related permissions

Have permissions been considered for this functionality?

  • No permission changes required
  • Permissions have been added / updated. Details:

PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

@lloback lloback requested review from a team as code owners November 4, 2022 07:50
@lloback lloback temporarily deployed to develop November 4, 2022 07:52 Inactive
@lloback lloback marked this pull request as draft November 4, 2022 07:54
@github-actions
Copy link

github-actions bot commented Nov 4, 2022

Visit the preview URL for this PR (updated for commit 10189cd):

https://jac-admin-develop--pr1788-feature-1725-late-ap-3agyaeok.web.app

(expires Sat, 17 Dec 2022 01:23:23 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0

@lloback lloback temporarily deployed to develop November 7, 2022 03:19 Inactive
@lloback lloback temporarily deployed to develop November 8, 2022 19:01 Inactive
Created the Message Component
Message status constant
@lloback lloback force-pushed the feature/1725-late-application branch from e322d0a to 7446993 Compare November 9, 2022 10:05
@lloback lloback temporarily deployed to develop November 9, 2022 10:07 Inactive
@warrensearle warrensearle temporarily deployed to develop November 9, 2022 10:50 Inactive
@lloback lloback temporarily deployed to develop November 17, 2022 01:21 Inactive
Copy link

@andrew-isaac andrew-isaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you let me know what you'd like tested? I got the pop up to approve a late application when logging in. I did this but every time I went back to the main overview of exercises I got the same pop up asking for approval.

@warrensearle
Copy link
Member

warrensearle commented Dec 1, 2022

Can you let me know what you'd like tested? I got the pop up to approve a late application when logging in. I did this but every time I went back to the main overview of exercises I got the same pop up asking for approval.

@andrew-isaac this is a draft pull request and so doesn't need review yet. Looks like the review requests were sent out by accident. Sorry!
The description template will be filled in with instructions etc and the PR marked as ready for review when it is ready for testing

@andrew-isaac
Copy link

haha no worries I thought I was going mad!

@warrensearle warrensearle deleted the feature/1725-late-application branch January 5, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants