Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1596 Eligibility report pagination #1605

Merged
merged 6 commits into from
Jul 8, 2022
Merged

#1596 Eligibility report pagination #1605

merged 6 commits into from
Jul 8, 2022

Conversation

HalcyonJAC
Copy link
Contributor

@HalcyonJAC HalcyonJAC commented Apr 6, 2022 •
edited
Loading

Author checklist

  • Include primary ticket number in title - e.g. "Show uploaded files in vacancy details page #123 New styling for widget" - and any additional tickets in description
  • Fill in the details below and delete as appropriate
  • Be proactive in getting your work approved 💪

What's included?

Add pagination items to the bottom of the table. See JAC Kit #57 Added pagination to bottom of table.

Who should test?

✅ Product owner
✅ Developers
✅ UTG

How to test?

Preview URL: https://jac-admin-develop--pr1605-feature-1596-eligibi-y6h4b37j.web.app

  • Make sure you use @jac-uk/jac-kit version 0.1.0
  • Open an exercise with eligibility issues in it
  • Check pagination functionality

Risk - how likely is this to impact other areas?

🟢 No risk - this is a self-contained piece of work

Additional context

Demo:

jac-admin-eligibility-issues-pagination

Related permissions

Have permissions been considered for this functionality?

  • No permission changes required

PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

@HalcyonJAC HalcyonJAC self-assigned this Apr 6, 2022
@HalcyonJAC HalcyonJAC mentioned this pull request Apr 6, 2022
Merged
@HalcyonJAC HalcyonJAC marked this pull request as ready for review June 14, 2022 12:03
@HalcyonJAC HalcyonJAC requested review from a team as code owners June 14, 2022 12:03
lloback
lloback reviewed Jun 16, 2022
View reviewed changes
Copy link
Contributor

@lloback lloback left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am having some errors on the TABLE on this branch locally. As I still cannot test on the live URL because my email was not part of the system, I will come back to this later.

image

@HalcyonJAC
Copy link
Contributor Author

I am having some errors on the TABLE on this branch locally. As I still cannot test on the live URL because my email was not part of the system, I will come back to this later.

image

Hi @lloback, could you run npm install to reinstall packages and then test it, please? On this branch I upgraded @jac-uk/jac-kit to 0.1.0.

andrew-isaac
andrew-isaac approved these changes Jun 17, 2022
View reviewed changes
Copy link

@andrew-isaac andrew-isaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@lloback
Copy link
Contributor

lloback commented Jun 17, 2022

Running NPM fixed the issue. Thanks. I don't see the numbers, just Previous and next buttons:

image

@HalcyonJAC
Copy link
Contributor Author

Running NPM fixed the issue. Thanks. I don't see the numbers, just Previous and next buttons:

image

Hi @lloback, do you use this exercise to do the testing?

Screen.Recording.2022-06-17.at.17.20.08.mov

tomlovesgithub
tomlovesgithub approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@tomlovesgithub tomlovesgithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally - again i am a big fan of this feature.

👏

@HalcyonJAC HalcyonJAC requested a review from warrensearle July 8, 2022 10:33
@warrensearle warrensearle removed their request for review July 8, 2022 10:45
@HalcyonJAC
Merge branch 'main' into feature/1596-eligibility-report-pagination
b0b32cd 
# Conflicts:
#	package-lock.json
#	package.json
#	src/store/auth.js
lloback
lloback reviewed Jul 8, 2022
View reviewed changes
Copy link
Contributor

@lloback lloback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is good to go.

@HalcyonJAC HalcyonJAC temporarily deployed to develop July 8, 2022 11:34 Inactive
@github-actions
Copy link

github-actions bot commented Jul 8, 2022

Visit the preview URL for this PR (updated for commit b0b32cd):

https://jac-admin-develop--pr1605-feature-1596-eligibi-y6h4b37j.web.app

(expires Sun, 07 Aug 2022 11:38:58 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@HalcyonJAC HalcyonJAC merged commit 8e2f680 into main Jul 8, 2022
@HalcyonJAC HalcyonJAC deleted the feature/1596-eligibility-report-pagination branch July 8, 2022 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lloback lloback lloback left review comments

@andrew-isaac andrew-isaac andrew-isaac approved these changes

@tomlovesgithub tomlovesgithub tomlovesgithub approved these changes

Assignees

@HalcyonJAC HalcyonJAC

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HalcyonJAC @lloback @tomlovesgithub @andrew-isaac