#1731 Bugfix: Exercise search #1732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warrensearle
requested review from
andrew-isaac,
tomlovesgithub,
lloback and
HalcyonJAC
and removed request for
lloback
|
Visit the preview URL for this PR (updated for commit 6e5cd86): https://jac-admin-develop--pr1732-bugfix-1731-exercise-ak2rapau.web.app (expires Sat, 12 Nov 2022 09:26:48 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
| @@ -199,11 +195,6 @@ export default { | |||
| this.$store.dispatch('exerciseCollection/storeItems', { items: this.selectedItems }); | |||
| this.$router.push({ name: 'exercises-export' }); | |||
| }, | |||
| exerciseSearch(searchTerm) { | |||
| return new Promise(resolve => { | |||
| resolve([searchTerm, searchTerm.toLowerCase(), searchTerm.toUpperCase()]); | |||
tomlovesgithub
approved these changes
Sep 21, 2022
andrew-isaac
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^
What's included?
Fixes exercise search
Who should test?
✅ Product owner
✅ Developers
✅ UTG
How to test?
Log in to admin, go to exercises list and search for an exercise.
Note the search is currently case sensitive and a "starts with" style search.
e.g. a search for "IA Test" will match the following:
but not the following:
Risk - how likely is this to impact other areas?
🟢 No risk - this is a self-contained piece of work
PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING