Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1731 Bugfix: Exercise search #1732

Merged
merged 4 commits into from
Oct 13, 2022
Merged

#1731 Bugfix: Exercise search #1732

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b3f0008
Exercise search fixed
warrensearle Sep 9, 2022
fbc60f9
Update jac-kit
warrensearle Sep 9, 2022
063cf3d
Remove wrong placeholder
warrensearle Sep 9, 2022
6e5cd86
Merge branch 'main' into bugfix/1731-exercise-search
tomlovesgithub Oct 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"dependencies": {
"@ckeditor/ckeditor5-build-classic": "^16.0.0",
"@ckeditor/ckeditor5-vue": "^1.0.3",
"@jac-uk/jac-kit": "0.1.3",
"@jac-uk/jac-kit": "^0.1.6",
"@ministryofjustice/frontend": "0.2.4",
"@sentry/browser": "^6.4.1",
"@sentry/integrations": "^6.4.1",
Expand Down
11 changes: 1 addition & 10 deletions src/views/Exercises.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,13 +65,9 @@
title: 'Open date',
},
]"
:search="['name']"
multi-select
:selection.sync="selectedItems"
:custom-search="{
placeholder: 'Search exercise names',
handler: exerciseSearch,
field: 'name',
}"
@change="getTableData"
>
<template #actions>
Expand Down Expand Up @@ -199,11 +195,6 @@ export default {
this.$store.dispatch('exerciseCollection/storeItems', { items: this.selectedItems });
this.$router.push({ name: 'exercises-export' });
},
exerciseSearch(searchTerm) {
return new Promise(resolve => {
resolve([searchTerm, searchTerm.toLowerCase(), searchTerm.toUpperCase()]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

});
},
},
};
</script>
Expand Down