Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1894/ show all applications under candidate #1918

Merged
merged 11 commits into from
Jun 2, 2023

Conversation

tomlovesgithub
Copy link
Contributor

@tomlovesgithub tomlovesgithub commented Feb 27, 2023

What's included?

All applications now show under candidates > candidate > applications (as opposed to only those marked as applied).
Sortable by exercise and status.

Who should test?

✅ Product owner
✅ Developers
✅ UTG

How to test?

  • Confirm the number of applications under candidates > candidate > applications matches the number shown in the candidates list.
  • Sort columns by exercise and status

Risk - how likely is this to impact other areas?

🟢 No risk - this is a self-contained piece of work


PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

@tomlovesgithub tomlovesgithub temporarily deployed to develop February 27, 2023 11:08 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Feb 27, 2023

Visit the preview URL for this PR (updated for commit 98cea63):

https://jac-admin-develop--pr1918-1894-draft-applicati-3u2pqdeu.web.app

(expires Sun, 02 Jul 2023 16:19:28 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0

@tomlovesgithub tomlovesgithub temporarily deployed to develop March 3, 2023 14:56 — with GitHub Actions Inactive
@tomlovesgithub tomlovesgithub temporarily deployed to develop March 3, 2023 17:31 — with GitHub Actions Inactive
@tomlovesgithub tomlovesgithub changed the title inital work + JACkit local 1894/ show all applications under candidate Mar 3, 2023
@tomlovesgithub tomlovesgithub temporarily deployed to develop March 3, 2023 17:44 — with GitHub Actions Inactive
@tomlovesgithub tomlovesgithub temporarily deployed to develop March 3, 2023 17:44 — with GitHub Actions Inactive
@tomlovesgithub tomlovesgithub temporarily deployed to develop March 9, 2023 13:30 — with GitHub Actions Inactive
@tomlovesgithub tomlovesgithub marked this pull request as ready for review March 16, 2023 18:22
@tomlovesgithub tomlovesgithub requested review from a team as code owners March 16, 2023 18:22
@tomlovesgithub tomlovesgithub temporarily deployed to develop March 17, 2023 16:58 — with GitHub Actions Inactive
@tomlovesgithub tomlovesgithub temporarily deployed to production March 21, 2023 15:54 — with GitHub Actions Inactive
@github-actions
Copy link

Visit the preview URL for this PR (updated for commit f638437):

https://jac-apply-admin-production--pr1918-1894-draft-applicat-kp2g9kn7.web.app

(expires Thu, 20 Apr 2023 15:58:01 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2f31b7832d58b04f07d3816f45a5d09d461ded5e

@tomlovesgithub tomlovesgithub temporarily deployed to develop March 21, 2023 16:10 — with GitHub Actions Inactive
Copy link
Member

@warrensearle warrensearle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomlovesgithub this is really good: nice, neat and useful 👍

@tomlovesgithub
Copy link
Contributor Author

This ticket is blocked/failing UT due to a lack of supporting indexes - we can settle these once the work is merged or before.

@tomlovesgithub tomlovesgithub temporarily deployed to develop June 2, 2023 09:26 — with GitHub Actions Inactive
@tomlovesgithub tomlovesgithub temporarily deployed to develop June 2, 2023 16:15 — with GitHub Actions Inactive
@tomlovesgithub tomlovesgithub merged commit 3839283 into main Jun 2, 2023
@tomlovesgithub tomlovesgithub deleted the 1894-draft-applications-under-candidate branch June 2, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants