Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show all candidate applications #99

Closed
wants to merge 4 commits into from

Conversation

tomlovesgithub
Copy link
Contributor

@tomlovesgithub tomlovesgithub commented Mar 3, 2023

See: admin 1918

@tomlovesgithub tomlovesgithub marked this pull request as ready for review March 6, 2023 14:23
methods: {
getTableData(params) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that getTableData will not be triggered when the component is mounted as noApplications is always true.

@warrensearle
Copy link
Member

warrensearle commented Mar 7, 2023

@tomlovesgithub I'm thinking this component was moved to the JAC Kit by accident as I can't see it being used anywhere other than in CandidatesView.vue in admin repo... so please feel free to move it out of the JAC Kit and into admin, probably in-line in CandidatesView.vue. That might help with the issue @HalcyonJAC spotted too

@warrensearle warrensearle deleted the show-all-candidate-applications branch March 21, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants