-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1944 Application Reminder Emails/Admin Email Signature Box #1958
Merged
HalcyonJAC
merged 12 commits into
main
from
feature/1944-application-reminder-email-signature-box
Apr 14, 2023
Merged
#1944 Application Reminder Emails/Admin Email Signature Box #1958
HalcyonJAC
merged 12 commits into
main
from
feature/1944-application-reminder-email-signature-box
Apr 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # package-lock.json
Visit the preview URL for this PR (updated for commit 1a5591f): https://jac-admin-develop--pr1958-feature-1944-applica-o5l96191.web.app (expires Sat, 06 May 2023 11:01:22 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0 |
HalcyonJAC
requested review from
andrew-isaac,
tomlovesgithub,
drieJAC and
warrensearle
April 6, 2023 10:59
andrew-isaac
approved these changes
Apr 6, 2023
warrensearle
approved these changes
Apr 11, 2023
tomlovesgithub
approved these changes
Apr 13, 2023
HalcyonJAC
deleted the
feature/1944-application-reminder-email-signature-box
branch
April 14, 2023 07:58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included?
Closes #1944
Who should test?
✅ Product owner
✅ Developers
✅ UTG
How to test?
Go to Contacts of an exercise and check if the email signature can accept a name rather than an email address.
Risk - how likely is this to impact other areas?
🟢 No risk - this is a self-contained piece of work
Additional context
Demo:
Screen.Recording.2023-04-06.at.10.03.08.mov
Related permissions
Have permissions been considered for this functionality?
PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING