Feature/2192 Monitor candidate data #2223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HalcyonJAC
force-pushed
the
feature/2192-monitor-candidate-data
branch
from
a472d53 to
0fa024a
Compare
|
Visit the preview URL for this PR (updated for commit 7bd8298): https://jac-admin-develop--pr2223-feature-2192-monitor-nc6omonq.web.app (expires Fri, 29 Dec 2023 11:36:08 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0 |
HalcyonJAC
force-pushed
the
feature/2192-monitor-candidate-data
branch
from
0fa024a to
49d2507
Compare
warrensearle
requested changes
Nov 21, 2023
There was a problem hiding this comment.
Hey @HalcyonJAC this needs a few tweaks so it is no longer specific to pre selection day questionnaires.
The candidateForm document you have access to includes some useful info:
task.type(in this case 'preSelectionDayQuestionnaire') can be used in the query forapplicationRecordswhen you are looking atpreSelectionDayQuestionnaire.statusopenDatecontains the date the emails are meant to be sentcloseDatecontains the date the questionnaires are meant to be returned by (the deadline)partsdefines what is being asked for in the questionnaire which may be useful in populating the email template (but probably not as the email should be fairly generic, I would expect)
HalcyonJAC
force-pushed
the
feature/2192-monitor-candidate-data
branch
from
10281af to
e59893f
Compare
HalcyonJAC
force-pushed
the
feature/2192-monitor-candidate-data
branch
from
7bf301e to
ae8c16c
Compare
HalcyonJAC
force-pushed
the
feature/2192-monitor-candidate-data
branch
from
f619d3f to
d06d6cd
Compare
HalcyonJAC
force-pushed
the
feature/2192-monitor-candidate-data
branch
from
d06d6cd to
fc9ae00
Compare
warrensearle
requested review from
Franceswog,
tomlovesgithub and
drieJAC
and removed request for
a team
warrensearle
merged commit 6929dd6
into
epic/2141-pre-selection-day-questionnaire
10 checks passed
warrensearle
added a commit
that referenced
this pull request
Dec 22, 2023
…#2222) * Add extra tasks * #1868 Selection Day MVP * Updates to task views and user journey * Support for EMP tie-breaker * BugFix: Changing advert type should not change exercise state * Bugfix: Panel pack search improvement * Bugfix: Create an exercise from clipboard not working * Bugfix: Applications list layout. Reduce margin * Bugfix: Task list. Application process not showing as Done * Bugfix: Exercise overview broken when unlocked * Bugfix: Stages search should include hint * Data entry. Layout tweaks * Fix lint * Support for shortlisting outcome * #2191 Configure Pre-selection day workflow * Add form validation * Text change * Added module for candidateForm. Added code to create the candidateForm. * Create candidateForm document on save * Fix naming and typo * Fixed incorrect send date * Update task first page to be called 'Overview' * Include constants * fix lints * Fix name change of date fields * Feature/2192 Monitor candidate data (#2223) * Add preSelectionDayQuestionnaires to store * Update Monitor component * rename function * reset error message * tidy up * tidy up * tidy up * update props * update permission * tidy up * #2226 Configure Candidate Availability (#2227) * #2226 Configure candidate availability * Tidy up now platform handles creation of candidateForm * Fix timeline dates * Fix save error * Open candidate form when requests are sent (for now) * Store panellist id and name rather than just id * Ensure date fields have a validation message * Show parts that are relevant to exercise * Close and continue button * Update PSDQ wording * Remove configuration of form parts --------- Co-authored-by: drieJac <jac.drie@digitalteam.uk> Co-authored-by: halcyonjac <halcyon@judicialappointments.digital> Co-authored-by: HalcyonJAC <79906532+HalcyonJAC@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included?
Closes #2192
Note: This PR will need the changes on digital-platform Feature/admin 2192.
Who should test?
✅ Product owner
✅ Developers
✅ UTG
How to test?
Example exercise:
Not requested
Requested
Risk - how likely is this to impact other areas?
🟠 Medium risk - this does change code that is shared with other areas
Additional context
Screen.Recording.2023-11-29.at.11.30.59.mov
Related permissions
Have permissions been considered for this functionality?
PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING