Bugfix/TS 199 Character Issues Report No Data #2336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit fcff6d6): https://jac-admin-develop--pr2336-bugfix-issue-199-cha-pj840g0x.web.app (expires Sat, 30 Mar 2024 11:44:04 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0 |
KoWeiJAC
requested review from
Franceswog,
tomlovesgithub,
drieJAC and
HalcyonJAC
HalcyonJAC
approved these changes
Feb 28, 2024
NormaJAC
approved these changes
Feb 28, 2024
tomlovesgithub
approved these changes
Feb 29, 2024
HalcyonJAC
changed the title
HalcyonJAC
deleted the
bugfix/issue-199-character-issue-report-no-data
branch
tomlovesgithub
added a commit
that referenced
this pull request
Mar 5, 2024
* Feature/2276 Make candidate responses to bespoke question on Ex.187 visible (#2277) * add Resignation from the Department for Work and Pensions (DWP) to application view * fix bug * add missing question and answer * check env * Bump version number to 1.22.0 * #2091/self assessment document extraction (#2235) * wip * working proto * use new jac kit * Update package-lock * Ensure application process is marked as done * update jac-kit * add content to review page * wip test * Removed test commit * working * tidy --------- Co-authored-by: warrensearle <warren@precise-minds.co.uk> Co-authored-by: drieJac <jac.drie@digitalteam.uk> * Bump version number to 1.23.0 * Bugfix/New user missing uid (#2289) * Added google analytics (#2292) * #2246 Disable Relevant Qualifications being added to application process for non-legal exercises (#2286) Co-authored-by: halcyonjac <halcyon@judicialappointments.digital> * Bump version number to 1.24.0 * Feature/2283 Add MS Word guidance to Self-assessment Exercise Downloads (#2288) * Feature/2230 Character declaration updates (#2278) * fix bugs and update wording * make current issues visible * remove 'All' options * fix no data issue when page loaded * Add labels to stage, status dropdown * change label and wording * change layout * filter available stage and status by application number * Update coding format * update coding format * fix stage, status dropdowns * fix loading issue * Fix text input * Epic/2150 issue ticketing system (#2299) * #2095 issue ticketing system (#2117) * Added feedback link. Added modal with basic feedback form. * Added feedback form with broswer info preloaded and if the user selects email as their contact details it preloads their email address. * Prepopularted display name and url * Disabled prepopulated fields. Using new jac-kit which allows disabling a text input. Added user id to the form data. Removed unnecessary styling. Left aligning modal form content. * Upgraded the jac-kit package * Added upload a screenshot. Added a list of contacts to be looped in. Now using getters for user details so no errors if form is called prior to login. Added criticality. Added previous action. Left aligned title. Added confirmation modal on submit. * Removed previous action as not needed * Show the feedback link for logged in users only * Removed selection of contact type, using email only. * Modified form to add/remove fields. Added a ticket number to the confirmation screen. * Update FeedbackForm.vue * Taking screenshots of canvas and displaying a thumbnail. Added icon to prevent text overlap for feedback button. * Added linkin title section to close modal. Re-using single modal. Make modal fixed width. * Use jac kit's modal * Added ability for the user to add feedback for a third part user, specifying their details. Move screenshot capture into its own component. * updated package lock after merge * Adding exercise id to the formData if available. Added bugReport collection and document store. Saving formData to the collection. * Modified text from applicant to candidate. Added warnings. Added a prompt for the user to check i the candidate is on a CPS machine. Display ticket number. Added code to create the bugreport record in the backend. * Renamed some of the attributes of the form. Added exercise ref. Now storing the exercise as an object. * Added application details to the bug report. * Replace feedback link with new one at bottom of page. Store screenshot in firestore storage and reference in bugReport document. Allow screenshot in the page to be removed. Display error if there is one uploading the screenshot. Removed old image. Upgraded to vue 3.26 to support expose functionality allowing parent component to call a method in the child. * Replaced capture screenshot image * Ensuring the new feedback link sits at a consistent distance from the bottom of the screen, accounting for the footer when fully scrolled. * Adjusted bottom position to account for the footer * Modified CPS question and nudged fixed link position. * updated package lock * Added call to callable function to create ZH issue. Added permission. Save downloadUrl and filepath in bugReport record. * Updated package lock file * Feedback link sticky with bottom footer * Updated package lock * Added observer to recalcuate link position when content of main-content div change. Refactored components. * Moved link html and css into dedicated component * Disable lint no-unused-vars for two lines * Added emits to component * Updated emit * Refactored * Updated vite with the port for local development * Remove unnecessary permissions for zenhub * Added fix for creating issue without screenshot --------- Co-authored-by: warrensearle <warren@precise-minds.co.uk> * Fixed an error in candidate submission due to there being no screenshot component present. (#2264) * Feature/2150 testing hooks (#2279) * Added hooks * WIP * Added lookup for slack member and custom error class. * Modified display of slack lookup form input * Pass the reporter userId in the callable function * Removed hardcoding * Added action button * Remove BR_ number from modal message * Added extra detail to the criticality types * Added logging to help identify bug. Added criticality mappings. * Added console logging to clicking feedback link * Added possible fix to sign user out if not signed in when click the feedback link * wip * removed unnecessary debugging in app.vue. Added checks for uid in feedback form with appropriate error. Added new error class. * Removed debugging * Updated package lock --------- Co-authored-by: warrensearle <warren@precise-minds.co.uk> * Feat/2285 remedy issues with character checks (#2298) * make character check records searchable * close modal if success --------- Co-authored-by: halcyonjac <halcyon@judicialappointments.digital> * Bump version number to 1.25.0 * Change EMP tie-breaker entry status to be 'Only 'SCC to reconsider' applications will be included'. Updated package lock. * Revert "Change EMP tie-breaker entry status to be 'Only 'SCC to reconsider' applications will be included'." This reverts commit 484bc29. * Upgrade Admin to use the latest Firebase library#1898 (#2287) * Refactor firebase app initialization to module API * tag TODOs * WIP * WIP: upgrade to module APIs * WIP: upgrade to module APIs * WIP: upgrade to module APIs * Upgrade to module APIs and fix user store * fix firestore query not loaded * Upgrade to module APIs * Upgrade to module APIs (httpsCallable) * Upgrade to module APIs * fix firestore query error * Fix create exercise * fix exercise._applications undefined error * add upgrade note * upgrade jac-kit * fix unit test of exercise document store * Upgrade to modular API * Upgrade to firebase modular APIs --------- Co-authored-by: halcyonjac <halcyon@judicialappointments.digital> * Change EMP tie-breaker entry status to be 'Only SCC to reconsider applications will be included'. (#2307) * Bugfix/User role with Microsoft email address (#2308) * add debugging logs * add logs * fix bug * remove console logs * Bump version number to 1.26.0 * Update issue templates * #2312 Enable vuexfire to handle collections (#2313) * Feature/qt 45 feedback report email (#2309) * wip * Added computed props and condition for displaying the button * Added exerciseId computed prop * Added ActionButton and ensuring it returns true immediately so just fires and forgets (as api call could take a while!) * Bump version number to 1.27.0 * Feat/2254 streamlined publication of external adverts (#2301) * Refactor firebase app initialization to module API * tag TODOs * WIP * WIP: upgrade to module APIs * WIP: upgrade to module APIs * WIP: upgrade to module APIs * Upgrade to module APIs and fix user store * fix firestore query not loaded * Upgrade to module APIs * Upgrade to module APIs (httpsCallable) * Upgrade to module APIs * fix firestore query error * Fix create exercise * fix exercise._applications undefined error * add upgrade note * upgrade jac-kit * fix unit test of exercise document store * Upgrade to modular API * Upgrade to firebase modular APIs * WIP: add external exercise preview page * WIP: redirect to external page if created * external vacancy overview * external exercise edit page * fix router * fix file not found error * fix external vacancy form * fix * modify layout * fix upload file * remove isExternalVacancy * allow to switch advert type * add back link * fix back button --------- Co-authored-by: halcyonjac <halcyon@judicialappointments.digital> * Feature/2275 Update reports which include stage status (#2295) * update diversity report * update outreach report * update diversity report on dashboard * update constant * use constant * update title using lookup * update hard-coded status * update status * update status * update status * update headers in the reports * remove empty status filter * Ticketing System #198 - BugFix MOJ Image Not Found As Not part Of Build (#2317) * Replace use of background image with alternative css solution to ensure the down arrow appears on the button. * Modified to use unicode for the arrow * Added the optional chaining operator on the attriburte and find method so that it works when no commissionerConflicts in additionalInfo. (#2316) * Feature/2281 Update Filters on Live Exercises index page (#2330) * update filters in exercise list * update jac kit to 4.0.1 * remove console.log * use arrayEmpty * update jac-kit to 4.0.2 * Bump version number to 1.28.0 * Feature/2280 Embed new version of application form for future exercises (#2310) * use application version 3 * fix working basis * check application version * fix total days * fix character information version * move workingBasisOptions to data object * Bugfix/Issue-190 Self assessment extraction (#2315) * add white-space pre-line to extracted content * fix bugs * improve naming * add order * update width * turn question to a dropdown * update questions * Bump version number to 1.29.0 * Bugfix/TS 199 Character Issues Report No Data (#2336) * fix firestore query * fix empty data when first loaded * renaming * Bump version number to 1.30.0 * Fix/2306 firebase permission error (#2335) * log errors of vuexfireJAC * fix firestore permission error * The uploadBytes function no longer returns the state in its response so even though the file upload was working the check for the state was returning undefined so an error was being erroneously displayed. (#2338) * Bump version number to 1.31.0 * #2154 Configure working preferences questions * Working preferences. Additional config and tabs * #2154 Configure working preferences questions * Fix lint error * Multiple choice shouldn't have the All option * wip * all broken * Fix location preferences, the rest to do (#2334) * fix display issues * fix display issues * wip * success * lint issue * testing issues --------- Co-authored-by: HalcyonJAC <79906532+HalcyonJAC@users.noreply.github.com> Co-authored-by: warrensearle <warren@precise-minds.co.uk> Co-authored-by: drieJac <jac.drie@digitalteam.uk> Co-authored-by: KoWeiJAC <156695133+KoWeiJAC@users.noreply.github.com> Co-authored-by: halcyonjac <halcyon@judicialappointments.digital> Co-authored-by: nickaddy <138654969+nickaddy@users.noreply.github.com>
HalcyonJAC
added a commit
that referenced
this pull request
Apr 11, 2024
* wip * all broken * Fix location preferences, the rest to do (#2334) * fix display issues * fix display issues * 1072/rebasing off main (#2341) * Feature/2276 Make candidate responses to bespoke question on Ex.187 visible (#2277) * add Resignation from the Department for Work and Pensions (DWP) to application view * fix bug * add missing question and answer * check env * Bump version number to 1.22.0 * #2091/self assessment document extraction (#2235) * wip * working proto * use new jac kit * Update package-lock * Ensure application process is marked as done * update jac-kit * add content to review page * wip test * Removed test commit * working * tidy --------- Co-authored-by: warrensearle <warren@precise-minds.co.uk> Co-authored-by: drieJac <jac.drie@digitalteam.uk> * Bump version number to 1.23.0 * Bugfix/New user missing uid (#2289) * Added google analytics (#2292) * #2246 Disable Relevant Qualifications being added to application process for non-legal exercises (#2286) Co-authored-by: halcyonjac <halcyon@judicialappointments.digital> * Bump version number to 1.24.0 * Feature/2283 Add MS Word guidance to Self-assessment Exercise Downloads (#2288) * Feature/2230 Character declaration updates (#2278) * fix bugs and update wording * make current issues visible * remove 'All' options * fix no data issue when page loaded * Add labels to stage, status dropdown * change label and wording * change layout * filter available stage and status by application number * Update coding format * update coding format * fix stage, status dropdowns * fix loading issue * Fix text input * Epic/2150 issue ticketing system (#2299) * #2095 issue ticketing system (#2117) * Added feedback link. Added modal with basic feedback form. * Added feedback form with broswer info preloaded and if the user selects email as their contact details it preloads their email address. * Prepopularted display name and url * Disabled prepopulated fields. Using new jac-kit which allows disabling a text input. Added user id to the form data. Removed unnecessary styling. Left aligning modal form content. * Upgraded the jac-kit package * Added upload a screenshot. Added a list of contacts to be looped in. Now using getters for user details so no errors if form is called prior to login. Added criticality. Added previous action. Left aligned title. Added confirmation modal on submit. * Removed previous action as not needed * Show the feedback link for logged in users only * Removed selection of contact type, using email only. * Modified form to add/remove fields. Added a ticket number to the confirmation screen. * Update FeedbackForm.vue * Taking screenshots of canvas and displaying a thumbnail. Added icon to prevent text overlap for feedback button. * Added linkin title section to close modal. Re-using single modal. Make modal fixed width. * Use jac kit's modal * Added ability for the user to add feedback for a third part user, specifying their details. Move screenshot capture into its own component. * updated package lock after merge * Adding exercise id to the formData if available. Added bugReport collection and document store. Saving formData to the collection. * Modified text from applicant to candidate. Added warnings. Added a prompt for the user to check i the candidate is on a CPS machine. Display ticket number. Added code to create the bugreport record in the backend. * Renamed some of the attributes of the form. Added exercise ref. Now storing the exercise as an object. * Added application details to the bug report. * Replace feedback link with new one at bottom of page. Store screenshot in firestore storage and reference in bugReport document. Allow screenshot in the page to be removed. Display error if there is one uploading the screenshot. Removed old image. Upgraded to vue 3.26 to support expose functionality allowing parent component to call a method in the child. * Replaced capture screenshot image * Ensuring the new feedback link sits at a consistent distance from the bottom of the screen, accounting for the footer when fully scrolled. * Adjusted bottom position to account for the footer * Modified CPS question and nudged fixed link position. * updated package lock * Added call to callable function to create ZH issue. Added permission. Save downloadUrl and filepath in bugReport record. * Updated package lock file * Feedback link sticky with bottom footer * Updated package lock * Added observer to recalcuate link position when content of main-content div change. Refactored components. * Moved link html and css into dedicated component * Disable lint no-unused-vars for two lines * Added emits to component * Updated emit * Refactored * Updated vite with the port for local development * Remove unnecessary permissions for zenhub * Added fix for creating issue without screenshot --------- Co-authored-by: warrensearle <warren@precise-minds.co.uk> * Fixed an error in candidate submission due to there being no screenshot component present. (#2264) * Feature/2150 testing hooks (#2279) * Added hooks * WIP * Added lookup for slack member and custom error class. * Modified display of slack lookup form input * Pass the reporter userId in the callable function * Removed hardcoding * Added action button * Remove BR_ number from modal message * Added extra detail to the criticality types * Added logging to help identify bug. Added criticality mappings. * Added console logging to clicking feedback link * Added possible fix to sign user out if not signed in when click the feedback link * wip * removed unnecessary debugging in app.vue. Added checks for uid in feedback form with appropriate error. Added new error class. * Removed debugging * Updated package lock --------- Co-authored-by: warrensearle <warren@precise-minds.co.uk> * Feat/2285 remedy issues with character checks (#2298) * make character check records searchable * close modal if success --------- Co-authored-by: halcyonjac <halcyon@judicialappointments.digital> * Bump version number to 1.25.0 * Change EMP tie-breaker entry status to be 'Only 'SCC to reconsider' applications will be included'. Updated package lock. * Revert "Change EMP tie-breaker entry status to be 'Only 'SCC to reconsider' applications will be included'." This reverts commit 484bc29. * Upgrade Admin to use the latest Firebase library#1898 (#2287) * Refactor firebase app initialization to module API * tag TODOs * WIP * WIP: upgrade to module APIs * WIP: upgrade to module APIs * WIP: upgrade to module APIs * Upgrade to module APIs and fix user store * fix firestore query not loaded * Upgrade to module APIs * Upgrade to module APIs (httpsCallable) * Upgrade to module APIs * fix firestore query error * Fix create exercise * fix exercise._applications undefined error * add upgrade note * upgrade jac-kit * fix unit test of exercise document store * Upgrade to modular API * Upgrade to firebase modular APIs --------- Co-authored-by: halcyonjac <halcyon@judicialappointments.digital> * Change EMP tie-breaker entry status to be 'Only SCC to reconsider applications will be included'. (#2307) * Bugfix/User role with Microsoft email address (#2308) * add debugging logs * add logs * fix bug * remove console logs * Bump version number to 1.26.0 * Update issue templates * #2312 Enable vuexfire to handle collections (#2313) * Feature/qt 45 feedback report email (#2309) * wip * Added computed props and condition for displaying the button * Added exerciseId computed prop * Added ActionButton and ensuring it returns true immediately so just fires and forgets (as api call could take a while!) * Bump version number to 1.27.0 * Feat/2254 streamlined publication of external adverts (#2301) * Refactor firebase app initialization to module API * tag TODOs * WIP * WIP: upgrade to module APIs * WIP: upgrade to module APIs * WIP: upgrade to module APIs * Upgrade to module APIs and fix user store * fix firestore query not loaded * Upgrade to module APIs * Upgrade to module APIs (httpsCallable) * Upgrade to module APIs * fix firestore query error * Fix create exercise * fix exercise._applications undefined error * add upgrade note * upgrade jac-kit * fix unit test of exercise document store * Upgrade to modular API * Upgrade to firebase modular APIs * WIP: add external exercise preview page * WIP: redirect to external page if created * external vacancy overview * external exercise edit page * fix router * fix file not found error * fix external vacancy form * fix * modify layout * fix upload file * remove isExternalVacancy * allow to switch advert type * add back link * fix back button --------- Co-authored-by: halcyonjac <halcyon@judicialappointments.digital> * Feature/2275 Update reports which include stage status (#2295) * update diversity report * update outreach report * update diversity report on dashboard * update constant * use constant * update title using lookup * update hard-coded status * update status * update status * update status * update headers in the reports * remove empty status filter * Ticketing System #198 - BugFix MOJ Image Not Found As Not part Of Build (#2317) * Replace use of background image with alternative css solution to ensure the down arrow appears on the button. * Modified to use unicode for the arrow * Added the optional chaining operator on the attriburte and find method so that it works when no commissionerConflicts in additionalInfo. (#2316) * Feature/2281 Update Filters on Live Exercises index page (#2330) * update filters in exercise list * update jac kit to 4.0.1 * remove console.log * use arrayEmpty * update jac-kit to 4.0.2 * Bump version number to 1.28.0 * Feature/2280 Embed new version of application form for future exercises (#2310) * use application version 3 * fix working basis * check application version * fix total days * fix character information version * move workingBasisOptions to data object * Bugfix/Issue-190 Self assessment extraction (#2315) * add white-space pre-line to extracted content * fix bugs * improve naming * add order * update width * turn question to a dropdown * update questions * Bump version number to 1.29.0 * Bugfix/TS 199 Character Issues Report No Data (#2336) * fix firestore query * fix empty data when first loaded * renaming * Bump version number to 1.30.0 * Fix/2306 firebase permission error (#2335) * log errors of vuexfireJAC * fix firestore permission error * The uploadBytes function no longer returns the state in its response so even though the file upload was working the check for the state was returning undefined so an error was being erroneously displayed. (#2338) * Bump version number to 1.31.0 * #2154 Configure working preferences questions * Working preferences. Additional config and tabs * #2154 Configure working preferences questions * Fix lint error * Multiple choice shouldn't have the All option * wip * all broken * Fix location preferences, the rest to do (#2334) * fix display issues * fix display issues * wip * success * lint issue * testing issues --------- Co-authored-by: HalcyonJAC <79906532+HalcyonJAC@users.noreply.github.com> Co-authored-by: warrensearle <warren@precise-minds.co.uk> Co-authored-by: drieJac <jac.drie@digitalteam.uk> Co-authored-by: KoWeiJAC <156695133+KoWeiJAC@users.noreply.github.com> Co-authored-by: halcyonjac <halcyon@judicialappointments.digital> Co-authored-by: nickaddy <138654969+nickaddy@users.noreply.github.com> * force reset * Update package-lock * wip mess * WIP less mess * 😫 * jurisdiction questions partial * Include local question renderer, for now * remove non-relevant config * add spacing between form field and save button * sort answers of multiple choice * fix display of linked question * fix display of additional preferences * fix display of no information * save answers of ranked choice correctly * fix warnings --------- Co-authored-by: warrensearle <warren@precise-minds.co.uk> Co-authored-by: HalcyonJAC <79906532+HalcyonJAC@users.noreply.github.com> Co-authored-by: drieJac <jac.drie@digitalteam.uk> Co-authored-by: KoWeiJAC <156695133+KoWeiJAC@users.noreply.github.com> Co-authored-by: halcyonjac <halcyon@judicialappointments.digital> Co-authored-by: nickaddy <138654969+nickaddy@users.noreply.github.com>
warrensearle
added a commit
that referenced
this pull request
Jul 1, 2024
* #2154 Configure working preferences questions * Working preferences. Additional config and tabs * #2154 Configure working preferences questions * Fix lint error * Multiple choice shouldn't have the All option * Added support for required fields. Added support for specifying a minumum number of answers for a question. * Upgraded jac-kit to fix RepeatableFields for linked questions * Updated lock file * Generate IDs for questions and answers * Fix lint error :) * Fix linked questions data model * View linked question * 1072/working prefs (#2340) * wip * all broken * Fix location preferences, the rest to do (#2334) * fix display issues * fix display issues * 1072/rebasing off main (#2341) * Feature/2276 Make candidate responses to bespoke question on Ex.187 visible (#2277) * add Resignation from the Department for Work and Pensions (DWP) to application view * fix bug * add missing question and answer * check env * Bump version number to 1.22.0 * #2091/self assessment document extraction (#2235) * wip * working proto * use new jac kit * Update package-lock * Ensure application process is marked as done * update jac-kit * add content to review page * wip test * Removed test commit * working * tidy --------- Co-authored-by: warrensearle <warren@precise-minds.co.uk> Co-authored-by: drieJac <jac.drie@digitalteam.uk> * Bump version number to 1.23.0 * Bugfix/New user missing uid (#2289) * Added google analytics (#2292) * #2246 Disable Relevant Qualifications being added to application process for non-legal exercises (#2286) Co-authored-by: halcyonjac <halcyon@judicialappointments.digital> * Bump version number to 1.24.0 * Feature/2283 Add MS Word guidance to Self-assessment Exercise Downloads (#2288) * Feature/2230 Character declaration updates (#2278) * fix bugs and update wording * make current issues visible * remove 'All' options * fix no data issue when page loaded * Add labels to stage, status dropdown * change label and wording * change layout * filter available stage and status by application number * Update coding format * update coding format * fix stage, status dropdowns * fix loading issue * Fix text input * Epic/2150 issue ticketing system (#2299) * #2095 issue ticketing system (#2117) * Added feedback link. Added modal with basic feedback form. * Added feedback form with broswer info preloaded and if the user selects email as their contact details it preloads their email address. * Prepopularted display name and url * Disabled prepopulated fields. Using new jac-kit which allows disabling a text input. Added user id to the form data. Removed unnecessary styling. Left aligning modal form content. * Upgraded the jac-kit package * Added upload a screenshot. Added a list of contacts to be looped in. Now using getters for user details so no errors if form is called prior to login. Added criticality. Added previous action. Left aligned title. Added confirmation modal on submit. * Removed previous action as not needed * Show the feedback link for logged in users only * Removed selection of contact type, using email only. * Modified form to add/remove fields. Added a ticket number to the confirmation screen. * Update FeedbackForm.vue * Taking screenshots of canvas and displaying a thumbnail. Added icon to prevent text overlap for feedback button. * Added linkin title section to close modal. Re-using single modal. Make modal fixed width. * Use jac kit's modal * Added ability for the user to add feedback for a third part user, specifying their details. Move screenshot capture into its own component. * updated package lock after merge * Adding exercise id to the formData if available. Added bugReport collection and document store. Saving formData to the collection. * Modified text from applicant to candidate. Added warnings. Added a prompt for the user to check i the candidate is on a CPS machine. Display ticket number. Added code to create the bugreport record in the backend. * Renamed some of the attributes of the form. Added exercise ref. Now storing the exercise as an object. * Added application details to the bug report. * Replace feedback link with new one at bottom of page. Store screenshot in firestore storage and reference in bugReport document. Allow screenshot in the page to be removed. Display error if there is one uploading the screenshot. Removed old image. Upgraded to vue 3.26 to support expose functionality allowing parent component to call a method in the child. * Replaced capture screenshot image * Ensuring the new feedback link sits at a consistent distance from the bottom of the screen, accounting for the footer when fully scrolled. * Adjusted bottom position to account for the footer * Modified CPS question and nudged fixed link position. * updated package lock * Added call to callable function to create ZH issue. Added permission. Save downloadUrl and filepath in bugReport record. * Updated package lock file * Feedback link sticky with bottom footer * Updated package lock * Added observer to recalcuate link position when content of main-content div change. Refactored components. * Moved link html and css into dedicated component * Disable lint no-unused-vars for two lines * Added emits to component * Updated emit * Refactored * Updated vite with the port for local development * Remove unnecessary permissions for zenhub * Added fix for creating issue without screenshot --------- Co-authored-by: warrensearle <warren@precise-minds.co.uk> * Fixed an error in candidate submission due to there being no screenshot component present. (#2264) * Feature/2150 testing hooks (#2279) * Added hooks * WIP * Added lookup for slack member and custom error class. * Modified display of slack lookup form input * Pass the reporter userId in the callable function * Removed hardcoding * Added action button * Remove BR_ number from modal message * Added extra detail to the criticality types * Added logging to help identify bug. Added criticality mappings. * Added console logging to clicking feedback link * Added possible fix to sign user out if not signed in when click the feedback link * wip * removed unnecessary debugging in app.vue. Added checks for uid in feedback form with appropriate error. Added new error class. * Removed debugging * Updated package lock --------- Co-authored-by: warrensearle <warren@precise-minds.co.uk> * Feat/2285 remedy issues with character checks (#2298) * make character check records searchable * close modal if success --------- Co-authored-by: halcyonjac <halcyon@judicialappointments.digital> * Bump version number to 1.25.0 * Change EMP tie-breaker entry status to be 'Only 'SCC to reconsider' applications will be included'. Updated package lock. * Revert "Change EMP tie-breaker entry status to be 'Only 'SCC to reconsider' applications will be included'." This reverts commit 484bc29. * Upgrade Admin to use the latest Firebase library#1898 (#2287) * Refactor firebase app initialization to module API * tag TODOs * WIP * WIP: upgrade to module APIs * WIP: upgrade to module APIs * WIP: upgrade to module APIs * Upgrade to module APIs and fix user store * fix firestore query not loaded * Upgrade to module APIs * Upgrade to module APIs (httpsCallable) * Upgrade to module APIs * fix firestore query error * Fix create exercise * fix exercise._applications undefined error * add upgrade note * upgrade jac-kit * fix unit test of exercise document store * Upgrade to modular API * Upgrade to firebase modular APIs --------- Co-authored-by: halcyonjac <halcyon@judicialappointments.digital> * Change EMP tie-breaker entry status to be 'Only SCC to reconsider applications will be included'. (#2307) * Bugfix/User role with Microsoft email address (#2308) * add debugging logs * add logs * fix bug * remove console logs * Bump version number to 1.26.0 * Update issue templates * #2312 Enable vuexfire to handle collections (#2313) * Feature/qt 45 feedback report email (#2309) * wip * Added computed props and condition for displaying the button * Added exerciseId computed prop * Added ActionButton and ensuring it returns true immediately so just fires and forgets (as api call could take a while!) * Bump version number to 1.27.0 * Feat/2254 streamlined publication of external adverts (#2301) * Refactor firebase app initialization to module API * tag TODOs * WIP * WIP: upgrade to module APIs * WIP: upgrade to module APIs * WIP: upgrade to module APIs * Upgrade to module APIs and fix user store * fix firestore query not loaded * Upgrade to module APIs * Upgrade to module APIs (httpsCallable) * Upgrade to module APIs * fix firestore query error * Fix create exercise * fix exercise._applications undefined error * add upgrade note * upgrade jac-kit * fix unit test of exercise document store * Upgrade to modular API * Upgrade to firebase modular APIs * WIP: add external exercise preview page * WIP: redirect to external page if created * external vacancy overview * external exercise edit page * fix router * fix file not found error * fix external vacancy form * fix * modify layout * fix upload file * remove isExternalVacancy * allow to switch advert type * add back link * fix back button --------- Co-authored-by: halcyonjac <halcyon@judicialappointments.digital> * Feature/2275 Update reports which include stage status (#2295) * update diversity report * update outreach report * update diversity report on dashboard * update constant * use constant * update title using lookup * update hard-coded status * update status * update status * update status * update headers in the reports * remove empty status filter * Ticketing System #198 - BugFix MOJ Image Not Found As Not part Of Build (#2317) * Replace use of background image with alternative css solution to ensure the down arrow appears on the button. * Modified to use unicode for the arrow * Added the optional chaining operator on the attriburte and find method so that it works when no commissionerConflicts in additionalInfo. (#2316) * Feature/2281 Update Filters on Live Exercises index page (#2330) * update filters in exercise list * update jac kit to 4.0.1 * remove console.log * use arrayEmpty * update jac-kit to 4.0.2 * Bump version number to 1.28.0 * Feature/2280 Embed new version of application form for future exercises (#2310) * use application version 3 * fix working basis * check application version * fix total days * fix character information version * move workingBasisOptions to data object * Bugfix/Issue-190 Self assessment extraction (#2315) * add white-space pre-line to extracted content * fix bugs * improve naming * add order * update width * turn question to a dropdown * update questions * Bump version number to 1.29.0 * Bugfix/TS 199 Character Issues Report No Data (#2336) * fix firestore query * fix empty data when first loaded * renaming * Bump version number to 1.30.0 * Fix/2306 firebase permission error (#2335) * log errors of vuexfireJAC * fix firestore permission error * The uploadBytes function no longer returns the state in its response so even though the file upload was working the check for the state was returning undefined so an error was being erroneously displayed. (#2338) * Bump version number to 1.31.0 * #2154 Configure working preferences questions * Working preferences. Additional config and tabs * #2154 Configure working preferences questions * Fix lint error * Multiple choice shouldn't have the All option * wip * all broken * Fix location preferences, the rest to do (#2334) * fix display issues * fix display issues * wip * success * lint issue * testing issues --------- Co-authored-by: HalcyonJAC <79906532+HalcyonJAC@users.noreply.github.com> Co-authored-by: warrensearle <warren@precise-minds.co.uk> Co-authored-by: drieJac <jac.drie@digitalteam.uk> Co-authored-by: KoWeiJAC <156695133+KoWeiJAC@users.noreply.github.com> Co-authored-by: halcyonjac <halcyon@judicialappointments.digital> Co-authored-by: nickaddy <138654969+nickaddy@users.noreply.github.com> * force reset * Update package-lock * wip mess * WIP less mess * 😫 * jurisdiction questions partial * Include local question renderer, for now * remove non-relevant config * add spacing between form field and save button * sort answers of multiple choice * fix display of linked question * fix display of additional preferences * fix display of no information * save answers of ranked choice correctly * fix warnings --------- Co-authored-by: warrensearle <warren@precise-minds.co.uk> Co-authored-by: HalcyonJAC <79906532+HalcyonJAC@users.noreply.github.com> Co-authored-by: drieJac <jac.drie@digitalteam.uk> Co-authored-by: KoWeiJAC <156695133+KoWeiJAC@users.noreply.github.com> Co-authored-by: halcyonjac <halcyon@judicialappointments.digital> Co-authored-by: nickaddy <138654969+nickaddy@users.noreply.github.com> * used jac-kit components * Update to use Tom's jac-kit components * Update to use fixed jac-kit * Update text for question about whether answers are required * Bug fixes * Fix editing and add backwards support for v1 data * Tidy up * Lint fixes * Support linked questions for master jurisdictions * Display 'other' jurisdiction from master list * Update package-lock * Update package-lock * Update package-lock --------- Co-authored-by: drieJac <jac.drie@digitalteam.uk> Co-authored-by: tomlovesgithub <44227249+tomlovesgithub@users.noreply.github.com> Co-authored-by: HalcyonJAC <79906532+HalcyonJAC@users.noreply.github.com> Co-authored-by: KoWeiJAC <156695133+KoWeiJAC@users.noreply.github.com> Co-authored-by: halcyonjac <halcyon@judicialappointments.digital> Co-authored-by: nickaddy <138654969+nickaddy@users.noreply.github.com> Co-authored-by: Tom Russell <TR115251@hotmail.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included?
For issue: https://app.zenhub.com/workspaces/platform-development-5ea838cd2aec471eb6d14139/issues/gh/jac-uk/ticketing-system/199
Who should test?
✅ Product owner
✅ Developers
✅ UTG
How to test?
Risk - how likely is this to impact other areas?
🟢 No risk - this is a self-contained piece of work
Additional context
Include screen grabs, video demo, notes etc.
Related permissions
Have permissions been considered for this functionality?
PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING