Update JCIO Agency Report #2366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit f3608a2): https://jac-admin-develop--pr2366-feat-2290-update-jci-t2buxw9l.web.app (expires Wed, 15 May 2024 13:44:13 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0 |
KoWeiJAC
requested review from
warrensearle,
tomlovesgithub,
HalcyonJAC,
drieJAC,
NormaJAC,
nickaddy and
Franceswog
nickaddy
requested changes
Apr 11, 2024
There was a problem hiding this comment.
@KoWeiJAC Perhaps my review should be on the other PR, because the Admin view is displaying correctly, but the download shows both applications whereas it should only show the one that is shown onscreen, i.e. the one that has ticked the 'carrying out of judicial functions' tickbox.
HalcyonJAC
force-pushed
the
feat/2290-update-JCIO-agency-report
branch
from
0b8a20f to
f3608a2
Compare
warrensearle
approved these changes
Apr 18, 2024
HalcyonJAC
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included?
Describe the changes included in this pull request and highlight dependencies with other repos/tickets
closes #2290
Who should test?
✅ Product owner
✅ Developers
✅ UTG
How to test?
Refreshto generate latest report dataExport Datato download the report, and check if the contents is correctRisk - how likely is this to impact other areas?
🟢 No risk - this is a self-contained piece of work
Additional context
Include screen grabs, video demo, notes etc.
Related permissions
Have permissions been considered for this functionality?
PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING