Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/admin 2290 update jcio agency report #1070

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

KoWeiJAC
Copy link
Contributor

@KoWeiJAC KoWeiJAC commented Apr 8, 2024

backend of this PR: jac-uk/admin#2366
To update the Agency JCIO report

@KoWeiJAC KoWeiJAC self-assigned this Apr 8, 2024
@KoWeiJAC KoWeiJAC marked this pull request as ready for review April 8, 2024 16:21
jcioOffice: helpers.toYesNo(application.feePaidOrSalariedJudge) || null,
jcioPosts: application.experience ? application.experience.map(e => e.jobTitle).join(', ') : null,
jcioOffice: helpers.toYesNo(anyJudicialFunctionExperiences) || null,
jcioPosts: anyJudicialFunctionExperiences ? judicialFunctionPosts.join(', ') : null,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the commas used to separate values into separate cells? (if so we may want to sanitise inputs incase they contain commas themselves)

Copy link
Contributor

@tomlovesgithub tomlovesgithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good, please see my comment!

@HalcyonJAC HalcyonJAC merged commit ce1cf79 into develop Apr 29, 2024
5 checks passed
@HalcyonJAC HalcyonJAC deleted the feat/admin-2290-update-JCIO-agency-report branch April 29, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants