Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support self-assessment extraction on Admin #2417

Merged
merged 4 commits into from
Jun 21, 2024

Conversation

drieJAC
Copy link
Contributor

@drieJAC drieJAC commented Jun 9, 2024

What's included?

Added ability for admin to upload/replace self assessment file and extract the content.
Added flag to application store to track status of extraction.

Closes #2411

Who should test?

✅ Product owner
✅ Developers
✅ UTG

How to test?

Screen.Recording.2024-06-10.at.00.43.19.mov

Risk - how likely is this to impact other areas?

🟢 No risk - this is a self-contained piece of work


PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

… the content.

Added flag to application store to track status of extraction.
@drieJAC drieJAC self-assigned this Jun 9, 2024
@drieJAC drieJAC requested review from a team as code owners June 9, 2024 23:42
Copy link

github-actions bot commented Jun 9, 2024

Visit the preview URL for this PR (updated for commit 513c316):

https://jac-admin-develop--pr2417-feature-2411-support-5ws5j0mb.web.app

(expires Sat, 20 Jul 2024 18:54:31 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0

@nickaddy
Copy link
Contributor

This is not doing the job, Omar, the content is extracted into a single field without any question titles and apparently without any word count. Look at this entry for an example of what extracted content should look like on the application view. You can follow the process from a candidate perspective on this exercise.

Allow individual answers to be submitted if within the word limit even if other answers exceed them.
Copy link
Contributor

@HalcyonJAC HalcyonJAC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

…this back up the chain.

Display word count when EditableField is not in the edit state.
Make the word count red when it has exceeded the word limit.
Copy link
Contributor

@nickaddy nickaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've nailed it, @drieJAC, thank you!

@drieJAC drieJAC merged commit f7e01e9 into main Jun 21, 2024
6 checks passed
@drieJAC drieJAC deleted the feature/2411-support-self-assessment-extraction branch June 21, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support self-assessment extraction on Admin (Application Edit)
5 participants