Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/2458 Add filters to Gantt chart #2504

Merged
merged 7 commits into from
Jul 29, 2024

Conversation

HalcyonJAC
Copy link
Contributor

@HalcyonJAC HalcyonJAC commented Jul 24, 2024

What's included?

Closes #2458

Related PRs:

Who should test?

✅ Product owner
✅ Developers
✅ UTG

How to test?

Preview URL:

Steps:

  1. Go to Programme View.
  2. Check if the filters work correctly.

Risk - how likely is this to impact other areas?

🟢 No risk - this is a self-contained piece of work

Additional context

Demo:

admin.2458.Add.filters.to.Gantt.chart.webm

Related permissions

Have permissions been considered for this functionality?

  • No permission changes required
  • Permissions have been added / updated. Details:

PREVIEW:PRODUCTION
can be OFF, DEVELOP or STAGING

Copy link

github-actions bot commented Jul 24, 2024

Visit the preview URL for this PR (updated for commit 135ff1a):

https://jac-admin-develop--pr2504-feature-2458-add-fil-utv430c8.web.app

(expires Wed, 28 Aug 2024 13:38:19 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0

@HalcyonJAC HalcyonJAC marked this pull request as ready for review July 25, 2024 11:18
@HalcyonJAC HalcyonJAC requested review from a team as code owners July 25, 2024 11:18
@nickaddy
Copy link
Contributor

@HalcyonJAC Is it possible to create a preview URL on Production pls? It will be much easier to test that way. 🙏

@HalcyonJAC HalcyonJAC requested review from warrensearle, NormaJAC and Franceswog and removed request for tomlovesgithub and KoWeiJAC July 25, 2024 11:40
Copy link

github-actions bot commented Jul 25, 2024

Visit the preview URL for this PR (updated for commit 135ff1a):

https://jac-apply-admin-production--pr2504-feature-2458-add-fi-r6234wm7.web.app

(expires Wed, 28 Aug 2024 13:44:54 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2f31b7832d58b04f07d3816f45a5d09d461ded5e

@nickaddy
Copy link
Contributor

@HalcyonJAC I'm experiencing a few issues with the filters:

image

  • The exercise types are not displaying correctly
  • The exercise types boxes should be ticked by default
  • When I select the top tickbox, I get a Loading message but nothing happens - could be connected with the issue above
  • Can we give a white background to the filter window so that you can't see the menu text appearing underneath?
  • I don't see any staff filters
  • I'm also puzzled as to why 233 is appearing at the top - there are no dates in the timeline.

@HalcyonJAC
Copy link
Contributor Author

@HalcyonJAC I'm experiencing a few issues with the filters:

image

  • The exercise types are not displaying correctly
  • The exercise types boxes should be ticked by default
  • When I select the top tickbox, I get a Loading message but nothing happens - could be connected with the issue above
  • Can we give a white background to the filter window so that you can't see the menu text appearing underneath?
  • I don't see any staff filters
  • I'm also puzzled as to why 233 is appearing at the top - there are no dates in the timeline.

@nickaddy I just deployed it again. Could you test it, please?

Copy link
Contributor

@nickaddy nickaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, @HalcyonJAC !

@HalcyonJAC HalcyonJAC merged commit a2253d9 into main Jul 29, 2024
9 checks passed
@HalcyonJAC HalcyonJAC deleted the feature/2458-add-filters-to-Gantt-chart branch July 29, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add filters to Gantt chart
4 participants