Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Update table filters #212

Merged
merged 6 commits into from
Jul 25, 2024
Merged

Feature/Update table filters #212

merged 6 commits into from
Jul 25, 2024

Conversation

HalcyonJAC
Copy link
Contributor

@HalcyonJAC HalcyonJAC commented Jul 25, 2024

What's included?

  1. Update the style of LoadingMessage component to make the spinner vertically align with the text.

  2. Update the z-index of SidePanel component.

    Before:

    image

    After:

    image

  3. Add the filter type groupOption to the table filters.

    Usage:

    const filters = [
      {
        title: '',
        type: 'groupOption',
        groups: [
          {
            title: 'Senior Selection Exercise Manager',
            field: 'seniorSelectionExerciseManager',
            type: 'option',
            options: [{ label: '', value: '' }],
          },
          {
            title: 'Selection Exercise Manager',
            field: 'selectionExerciseManager',
            type: 'option',
            options: [{ label: '', value: '' }],
          },
        ],
      }
    ]

    Demo:

    video-29884748-1e14e09c13392a2426deb8f43f05f0de.webm

@HalcyonJAC HalcyonJAC self-assigned this Jul 25, 2024
@HalcyonJAC HalcyonJAC marked this pull request as ready for review July 25, 2024 12:32
@HalcyonJAC HalcyonJAC requested a review from drieJAC July 25, 2024 12:32
@HalcyonJAC HalcyonJAC merged commit e963160 into main Jul 25, 2024
@HalcyonJAC HalcyonJAC deleted the feature/update-table-filters branch July 25, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants