Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/2631 SCC Report Summary page #1282

Merged
merged 14 commits into from
Dec 20, 2024
Merged

Feature/2631 SCC Report Summary page #1282

merged 14 commits into from
Dec 20, 2024

Conversation

HalcyonJAC
Copy link
Contributor

@HalcyonJAC HalcyonJAC self-assigned this Dec 12, 2024
@KoWeiJAC KoWeiJAC marked this pull request as ready for review December 18, 2024 09:20
drieJAC
drieJAC requested changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@drieJAC drieJAC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need some tests written for the permissions for these new callable functions please.
See the test/rules folder in DP.
Maybe some ones in test/actions too?

@HalcyonJAC HalcyonJAC force-pushed the feat/2631-SCC-report-summary-page branch from 8f489f8 to 556705c Compare December 20, 2024 11:17
@KoWeiJAC KoWeiJAC requested a review from drieJAC December 20, 2024 12:19
@KoWeiJAC
Copy link
Contributor

Need some tests written for the permissions for these new callable functions please. See the test/rules folder in DP. Maybe some ones in test/actions too?

@drieJAC
I added tests for permissions and related helper functions.
Could you help to review it again ? Thanks !

drieJAC
drieJAC requested changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@drieJAC drieJAC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think because you have added a new entry to firestore.rules you should add a test in the test/rules/3.exercises.spec.js file as well.
Give me a shout if you want me to show you.

@KoWeiJAC
Copy link
Contributor

i think because you have added a new entry to firestore.rules you should add a test in the test/rules/3.exercises.spec.js file as well. Give me a shout if you want me to show you.

@drieJAC I added the tests for firestore rules, could you help to review it again ? Thanks!

@KoWeiJAC KoWeiJAC requested a review from drieJAC December 20, 2024 16:08
@KoWeiJAC KoWeiJAC merged commit c2ec724 into develop Dec 20, 2024
5 checks passed
@KoWeiJAC KoWeiJAC deleted the feat/2631-SCC-report-summary-page branch December 20, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drieJAC drieJAC drieJAC approved these changes

Assignees

@HalcyonJAC HalcyonJAC

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SCC Report Summary page
3 participants
@HalcyonJAC @KoWeiJAC @drieJAC