Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/1244 hide email of assessment link #1293

Merged
merged 10 commits into from
Jan 13, 2025
Merged

Feat/1244 hide email of assessment link #1293

merged 10 commits into from
Jan 13, 2025

Conversation

KoWeiJAC
Copy link
Contributor

close #1244

  • Send sign-in request link
  • Send sign-in link
  • Create firebase email link for sign-in
  • Get test assessment link

@KoWeiJAC KoWeiJAC self-assigned this Dec 24, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 24, 2024
View reviewed changes
functions/shared/token.js Dismissed Show dismissed Hide dismissed
functions/shared/token.js Dismissed Show dismissed Hide dismissed
@KoWeiJAC
Copy link
Contributor Author

@nickaddy
We'll need to add email templates for sign-in request link and sign-in link notification.
We have following customised variables at the moment:

  • assessorName
  • applicantName
  • exerciseName
  • xCompetencyAreasOrXSkillsAndAbilities
  • submitAssessmentDueDate
  • uploadUrl
  • downloadUrl
  • exerciseMailbox
  • exercisePhoneNumber
  • selectionExerciseManager

@KoWeiJAC KoWeiJAC marked this pull request as ready for review December 27, 2024 13:10
@HalcyonJAC HalcyonJAC force-pushed the feat/1244-hide-email-of-assessment-link branch from 1ceb2d1 to c4c382d Compare December 27, 2024 15:00
@HalcyonJAC HalcyonJAC force-pushed the feat/1244-hide-email-of-assessment-link branch from c4c382d to 37d7598 Compare January 13, 2025 12:20
@KoWeiJAC KoWeiJAC merged commit 9a197e6 into develop Jan 13, 2025
4 checks passed
@KoWeiJAC KoWeiJAC deleted the feat/1244-hide-email-of-assessment-link branch January 13, 2025 15:34
HalcyonJAC pushed a commit that referenced this pull request Jan 13, 2025
@KoWeiJAC
Revert "Feat/1244 hide email of assessment link (#1293)"
078071f 
This reverts commit 9a197e6.
KoWeiJAC added a commit that referenced this pull request Jan 13, 2025
@KoWeiJAC
Revert "Feat/1244 hide email of assessment link (#1293)" (#1302)
b17b6d8 
This reverts commit 9a197e6.
@KoWeiJAC
Copy link
Contributor Author

Development Note:
Has been revert, so it won't block other releases.
But it needs to be added to develop branch again when is ready for release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomlovesgithub tomlovesgithub tomlovesgithub approved these changes

@drieJAC drieJAC Awaiting requested review from drieJAC

@warrensearle warrensearle Awaiting requested review from warrensearle

@HalcyonJAC HalcyonJAC Awaiting requested review from HalcyonJAC

Assignees

@KoWeiJAC KoWeiJAC

Labels
Needs UT
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4.14 URL query strings
3 participants
@KoWeiJAC @tomlovesgithub @drieJAC