Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1279 TECH DEBT - Reduce footprint of callable functions as reaching limit #1297

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

1279 TECH DEBT - Reduce footprint of callable functions as reaching limit #1297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abb07a4
Rejigged callable functions so as many as possible are now imported f…
drieJAC Jan 6, 2025
112d464
Importing callable functions as modules
drieJAC Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions ...ns/callableFunctions/cancelAssessments.js → ...unctions/assessments/cancelAssessments.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import functions from 'firebase-functions';
import config from '../shared/config.js';
import { firebase, db } from '../shared/admin.js';
import { checkArguments } from '../shared/helpers.js';
import initAssessments from '../actions/assessments.js';
import initServiceSettings from '../shared/serviceSettings.js';
import { PERMISSIONS, hasPermissions } from '../shared/permissions.js';
import config from '../../shared/config.js';
import { firebase, db } from '../../shared/admin.js';
import { checkArguments } from '../../shared/helpers.js';
import initAssessments from '../../actions/assessments.js';
import initServiceSettings from '../../shared/serviceSettings.js';
import { PERMISSIONS, hasPermissions } from '../../shared/permissions.js';

const { cancelAssessments } = initAssessments(config, firebase, db);
const { checkFunctionEnabled } = initServiceSettings(db);
Expand Down
11 changes: 11 additions & 0 deletions functions/callableFunctions/assessments/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import initialiseAssessments from './initialiseAssessments.js';
import cancelAssessments from './cancelAssessments.js';
import resetAssessments from './resetAssessments.js';
import sendAssessmentRequests from './sendAssessmentRequests.js';

export {
cancelAssessments,
initialiseAssessments,
resetAssessments,
sendAssessmentRequests
};
12 changes: 6 additions & 6 deletions ...allableFunctions/initialiseAssessments.js → ...ions/assessments/initialiseAssessments.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import functions from 'firebase-functions';
import config from '../shared/config.js';
import { firebase, db } from '../shared/admin.js';
import { checkArguments } from '../shared/helpers.js';
import initAssessments from '../actions/assessments.js';
import initServiceSettings from '../shared/serviceSettings.js';
import { PERMISSIONS, hasPermissions } from '../shared/permissions.js';
import config from '../../shared/config.js';
import { firebase, db } from '../../shared/admin.js';
import { checkArguments } from '../../shared/helpers.js';
import initAssessments from '../../actions/assessments.js';
import initServiceSettings from '../../shared/serviceSettings.js';
import { PERMISSIONS, hasPermissions } from '../../shared/permissions.js';

const { initialiseAssessments } = initAssessments(config, firebase, db);
const { checkFunctionEnabled } = initServiceSettings(db);
Expand Down
12 changes: 6 additions & 6 deletions ...ons/callableFunctions/resetAssessments.js → ...Functions/assessments/resetAssessments.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import functions from 'firebase-functions';
import config from '../shared/config.js';
import { firebase, db } from '../shared/admin.js';
import { checkArguments } from '../shared/helpers.js';
import initAssessments from '../actions/assessments.js';
import initServiceSettings from '../shared/serviceSettings.js';
import { PERMISSIONS, hasPermissions } from '../shared/permissions.js';
import config from '../../shared/config.js';
import { firebase, db } from '../../shared/admin.js';
import { checkArguments } from '../../shared/helpers.js';
import initAssessments from '../../actions/assessments.js';
import initServiceSettings from '../../shared/serviceSettings.js';
import { PERMISSIONS, hasPermissions } from '../../shared/permissions.js';

const { resetAssessments } = initAssessments(config, firebase, db);
const { checkFunctionEnabled } = initServiceSettings(db);
Expand Down
12 changes: 6 additions & 6 deletions ...llableFunctions/sendAssessmentRequests.js → ...ons/assessments/sendAssessmentRequests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import functions from 'firebase-functions';
import config from '../shared/config.js';
import { firebase, db } from '../shared/admin.js';
import { checkArguments } from '../shared/helpers.js';
import initAssessments from '../actions/assessments.js';
import initServiceSettings from '../shared/serviceSettings.js';
import { PERMISSIONS, hasPermissions } from '../shared/permissions.js';
import config from '../../shared/config.js';
import { firebase, db } from '../../shared/admin.js';
import { checkArguments } from '../../shared/helpers.js';
import initAssessments from '../../actions/assessments.js';
import initServiceSettings from '../../shared/serviceSettings.js';
import { PERMISSIONS, hasPermissions } from '../../shared/permissions.js';

const { sendAssessmentRequests } = initAssessments(config, firebase, db);
const { checkFunctionEnabled } = initServiceSettings(db);
Expand Down
19 changes: 19 additions & 0 deletions functions/callableFunctions/notifications/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
import processNotificationsNow from './processNotifications.js';
import sendApplicationReminders from './sendApplicationReminders.js';
import sendAssessmentReminders from './sendAssessmentReminders.js';
import sendCandidateFormNotifications from './sendCandidateFormNotifications.js';
import sendCharacterCheckRequests from './sendCharacterCheckRequests.js';
import sendPublishedFeedbackReportNotifications from './sendPublishedFeedbackReportNotifications.js';
import sendSmsVerificationCode from './sendSmsVerificationCode.js';
import testAssessmentNotification from './testAssessmentNotification.js';

export {
processNotificationsNow,
sendApplicationReminders,
sendAssessmentReminders,
sendCandidateFormNotifications,
sendCharacterCheckRequests,
sendPublishedFeedbackReportNotifications,
sendSmsVerificationCode,
testAssessmentNotification
};
10 changes: 5 additions & 5 deletions ...callableFunctions/processNotifications.js → ...ons/notifications/processNotifications.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import functions from 'firebase-functions';
import config from '../shared/config.js';
import { db, firebase } from '../shared/admin.js';
import initNotifications from '../actions/notifications.js';
import initServiceSettings from '../shared/serviceSettings.js';
import { PERMISSIONS, hasPermissions } from '../shared/permissions.js';
import config from '../../shared/config.js';
import { db, firebase } from '../../shared/admin.js';
import initNotifications from '../../actions/notifications.js';
import initServiceSettings from '../../shared/serviceSettings.js';
import { PERMISSIONS, hasPermissions } from '../../shared/permissions.js';

const { processNotifications } = initNotifications(config, firebase, db);
const { checkFunctionEnabled } = initServiceSettings(db);
Expand Down
12 changes: 6 additions & 6 deletions ...ableFunctions/sendApplicationReminders.js → ...notifications/sendApplicationReminders.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import functions from 'firebase-functions';
import config from '../shared/config.js';
import { firebase, db, auth } from '../shared/admin.js';
import { checkArguments } from '../shared/helpers.js';
import initApplications from '../actions/applications/applications.js';
import initServiceSettings from '../shared/serviceSettings.js';
import { PERMISSIONS, hasPermissions } from '../shared/permissions.js';
import config from '../../shared/config.js';
import { firebase, db, auth } from '../../shared/admin.js';
import { checkArguments } from '../../shared/helpers.js';
import initApplications from '../../actions/applications/applications.js';
import initServiceSettings from '../../shared/serviceSettings.js';
import { PERMISSIONS, hasPermissions } from '../../shared/permissions.js';

const { sendApplicationReminders } = initApplications(config, firebase, db, auth);
const { checkFunctionEnabled } = initServiceSettings(db);
Expand Down
12 changes: 6 additions & 6 deletions ...lableFunctions/sendAssessmentReminders.js → .../notifications/sendAssessmentReminders.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import functions from 'firebase-functions';
import config from '../shared/config.js';
import { firebase, db } from '../shared/admin.js';
import { checkArguments } from '../shared/helpers.js';
import initAssessments from '../actions/assessments.js';
import initServiceSettings from '../shared/serviceSettings.js';
import { PERMISSIONS, hasPermissions } from '../shared/permissions.js';
import config from '../../shared/config.js';
import { firebase, db } from '../../shared/admin.js';
import { checkArguments } from '../../shared/helpers.js';
import initAssessments from '../../actions/assessments.js';
import initServiceSettings from '../../shared/serviceSettings.js';
import { PERMISSIONS, hasPermissions } from '../../shared/permissions.js';

const { sendAssessmentReminders } = initAssessments(config, firebase, db);
const { checkFunctionEnabled } = initServiceSettings(db);
Expand Down
12 changes: 6 additions & 6 deletions ...nctions/sendCandidateFormNotifications.js → ...cations/sendCandidateFormNotifications.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import functions from 'firebase-functions';
import config from '../shared/config.js';
import { firebase, db, auth } from '../shared/admin.js';
import { checkArguments } from '../shared/helpers.js';
import initApplications from '../actions/applications/applications.js';
import initServiceSettings from '../shared/serviceSettings.js';
import { PERMISSIONS, hasPermissions } from '../shared/permissions.js';
import config from '../../shared/config.js';
import { firebase, db, auth } from '../../shared/admin.js';
import { checkArguments } from '../../shared/helpers.js';
import initApplications from '../../actions/applications/applications.js';
import initServiceSettings from '../../shared/serviceSettings.js';
import { PERMISSIONS, hasPermissions } from '../../shared/permissions.js';

const { sendCandidateFormNotifications } = initApplications(config, firebase, db, auth);
const { checkFunctionEnabled } = initServiceSettings(db);
Expand Down
12 changes: 6 additions & 6 deletions ...leFunctions/sendCharacterCheckRequests.js → ...tifications/sendCharacterCheckRequests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import functions from 'firebase-functions';
import config from '../shared/config.js';
import { firebase, db, auth } from '../shared/admin.js';
import { checkArguments } from '../shared/helpers.js';
import initApplications from '../actions/applications/applications.js';
import initServiceSettings from '../shared/serviceSettings.js';
import { PERMISSIONS, hasPermissions } from '../shared/permissions.js';
import config from '../../shared/config.js';
import { firebase, db, auth } from '../../shared/admin.js';
import { checkArguments } from '../../shared/helpers.js';
import initApplications from '../../actions/applications/applications.js';
import initServiceSettings from '../../shared/serviceSettings.js';
import { PERMISSIONS, hasPermissions } from '../../shared/permissions.js';

const { sendCharacterCheckRequests } = initApplications(config, firebase, db, auth);
const { checkFunctionEnabled } = initServiceSettings(db);
Expand Down
10 changes: 5 additions & 5 deletions ...ndPublishedFeedbackReportNotifications.js → ...ndPublishedFeedbackReportNotifications.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import functions from 'firebase-functions';
import config from '../shared/config.js';
import { firebase, db, auth } from '../shared/admin.js';
import initApplications from '../actions/applications/applications.js';
import initServiceSettings from '../shared/serviceSettings.js';
import { PERMISSIONS, hasPermissions } from '../shared/permissions.js';
import config from '../../shared/config.js';
import { firebase, db, auth } from '../../shared/admin.js';
import initApplications from '../../actions/applications/applications.js';
import initServiceSettings from '../../shared/serviceSettings.js';
import { PERMISSIONS, hasPermissions } from '../../shared/permissions.js';

const { sendPublishedFeedbackReportNotifications } = initApplications(config, firebase, db, auth);
const { checkFunctionEnabled } = initServiceSettings(db);
Expand Down
10 changes: 5 additions & 5 deletions ...lableFunctions/sendSmsVerificationCode.js → .../notifications/sendSmsVerificationCode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import functions from 'firebase-functions';
import config from '../shared/config.js';
import { firebase, db } from '../shared/admin.js';
import initServiceSettings from '../shared/serviceSettings.js';
import initVerification from '../actions/candidates/verification.js';
import { checkArguments } from '../shared/helpers.js';
import config from '../../shared/config.js';
import { firebase, db } from '../../shared/admin.js';
import initServiceSettings from '../../shared/serviceSettings.js';
import initVerification from '../../actions/candidates/verification.js';
import { checkArguments } from '../../shared/helpers.js';

const { checkFunctionEnabled } = initServiceSettings(db);
const { sendSmsCode } = initVerification(config, firebase, db);
Expand Down
12 changes: 6 additions & 6 deletions ...leFunctions/testAssessmentNotification.js → ...tifications/testAssessmentNotification.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import functions from 'firebase-functions';
import config from '../shared/config.js';
import { firebase, db } from '../shared/admin.js';
import { checkArguments } from '../shared/helpers.js';
import initAssessments from '../actions/assessments.js';
import initServiceSettings from '../shared/serviceSettings.js';
import { PERMISSIONS, hasPermissions } from '../shared/permissions.js';
import config from '../../shared/config.js';
import { firebase, db } from '../../shared/admin.js';
import { checkArguments } from '../../shared/helpers.js';
import initAssessments from '../../actions/assessments.js';
import initServiceSettings from '../../shared/serviceSettings.js';
import { PERMISSIONS, hasPermissions } from '../../shared/permissions.js';

const { testAssessmentNotification } = initAssessments(config, firebase, db);
const { checkFunctionEnabled } = initServiceSettings(db);
Expand Down
12 changes: 6 additions & 6 deletions functions/callableFunctions/customReport.js → ...callableFunctions/reports/customReport.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import functions from 'firebase-functions';
import { auth } from '../shared/admin.js';
import config from '../shared/config.js';
import { firebase, db } from '../shared/admin.js';
import initCustomReport from '../actions/exercises/customReport.js';
import initServiceSettings from '../shared/serviceSettings.js';
import { PERMISSIONS, hasPermissions } from '../shared/permissions.js';
import { auth } from '../../shared/admin.js';
import config from '../../shared/config.js';
import { firebase, db } from '../../shared/admin.js';
import initCustomReport from '../../actions/exercises/customReport.js';
import initServiceSettings from '../../shared/serviceSettings.js';
import { PERMISSIONS, hasPermissions } from '../../shared/permissions.js';

const { customReport } = initCustomReport(config, firebase, db, auth);
const { checkFunctionEnabled } = initServiceSettings(db);
Expand Down
12 changes: 6 additions & 6 deletions ...llableFunctions/exportSccSummaryReport.js → ...nctions/reports/exportSccSummaryReport.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import functions from 'firebase-functions';
import { firebase, db, auth } from '../shared/admin.js';
import initExportSccSummaryReport from '../actions/exercises/sccSummaryReport.js';
import { getDocument } from '../shared/helpers.js';
import initLogEvent from '../actions/logs/logEvent.js';
import initServiceSettings from '../shared/serviceSettings.js';
import { PERMISSIONS, hasPermissions } from '../shared/permissions.js';
import { firebase, db, auth } from '../../shared/admin.js';
import initExportSccSummaryReport from '../../actions/exercises/sccSummaryReport.js';
import { getDocument } from '../../shared/helpers.js';
import initLogEvent from '../../actions/logs/logEvent.js';
import initServiceSettings from '../../shared/serviceSettings.js';
import { PERMISSIONS, hasPermissions } from '../../shared/permissions.js';

const { exportSccSummaryReport } = initExportSccSummaryReport(firebase, db);
const { logEvent } = initLogEvent(firebase, db, auth);
Expand Down
12 changes: 6 additions & 6 deletions ...callableFunctions/generateAgencyReport.js → ...Functions/reports/generateAgencyReport.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import functions from 'firebase-functions';
import { firebase, db, auth } from '../shared/admin.js';
import initGenerateAgencyReport from '../actions/exercises/generateAgencyReport.js';
import { getDocument } from '../shared/helpers.js';
import initLogEvent from '../actions/logs/logEvent.js';
import initServiceSettings from '../shared/serviceSettings.js';
import { PERMISSIONS, hasPermissions } from '../shared/permissions.js';
import { firebase, db, auth } from '../../shared/admin.js';
import initGenerateAgencyReport from '../../actions/exercises/generateAgencyReport.js';
import { getDocument } from '../../shared/helpers.js';
import initLogEvent from '../../actions/logs/logEvent.js';
import initServiceSettings from '../../shared/serviceSettings.js';
import { PERMISSIONS, hasPermissions } from '../../shared/permissions.js';

const { generateAgencyReport } = initGenerateAgencyReport(firebase, db);
const { logEvent } = initLogEvent(firebase, db, auth);
Expand Down
14 changes: 7 additions & 7 deletions ...ableFunctions/generateDeploymentReport.js → ...tions/reports/generateDeploymentReport.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import functions from 'firebase-functions';
import config from '../shared/config.js';
import { firebase, db, auth } from '../shared/admin.js';
import initGenerateDeploymentReport from '../actions/exercises/generateDeploymentReport.js';
import { getDocument } from '../shared/helpers.js';
import initLogEvent from '../actions/logs/logEvent.js';
import initServiceSettings from '../shared/serviceSettings.js';
import { PERMISSIONS, hasPermissions } from '../shared/permissions.js';
import config from '../../shared/config.js';
import { firebase, db, auth } from '../../shared/admin.js';
import initGenerateDeploymentReport from '../../actions/exercises/generateDeploymentReport.js';
import { getDocument } from '../../shared/helpers.js';
import initLogEvent from '../../actions/logs/logEvent.js';
import initServiceSettings from '../../shared/serviceSettings.js';
import { PERMISSIONS, hasPermissions } from '../../shared/permissions.js';

const { generateDeploymentReport } = initGenerateDeploymentReport(config, firebase, db);
const { logEvent } = initLogEvent(firebase, db, auth);
Expand Down
8 changes: 4 additions & 4 deletions ...allableFunctions/generateDiversityData.js → ...unctions/reports/generateDiversityData.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import functions from 'firebase-functions';
import { firebase, db } from '../shared/admin.js';
import initGenerateDiversityData from '../actions/exercises/generateDiversityData.js';
import initServiceSettings from '../shared/serviceSettings.js';
import { PERMISSIONS, hasPermissions } from '../shared/permissions.js';
import { firebase, db } from '../../shared/admin.js';
import initGenerateDiversityData from '../../actions/exercises/generateDiversityData.js';
import initServiceSettings from '../../shared/serviceSettings.js';
import { PERMISSIONS, hasPermissions } from '../../shared/permissions.js';

const { generateDiversityData } = initGenerateDiversityData(firebase, db);
const { checkFunctionEnabled } = initServiceSettings(db);
Expand Down
16 changes: 8 additions & 8 deletions ...lableFunctions/generateDiversityReport.js → ...ctions/reports/generateDiversityReport.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import functions from 'firebase-functions';
import config from '../shared/config.js';
import { firebase, db, auth } from '../shared/admin.js';
import initGenerateDiversityReport from '../actions/exercises/generateDiversityReport.js';
import initGenerateDiversityData from '../actions/exercises/generateDiversityData.js';
import { getDocument } from '../shared/helpers.js';
import initLogEvent from '../actions/logs/logEvent.js';
import initServiceSettings from '../shared/serviceSettings.js';
import { PERMISSIONS, hasPermissions } from '../shared/permissions.js';
import config from '../../shared/config.js';
import { firebase, db, auth } from '../../shared/admin.js';
import initGenerateDiversityReport from '../../actions/exercises/generateDiversityReport.js';
import initGenerateDiversityData from '../../actions/exercises/generateDiversityData.js';
import { getDocument } from '../../shared/helpers.js';
import initLogEvent from '../../actions/logs/logEvent.js';
import initServiceSettings from '../../shared/serviceSettings.js';
import { PERMISSIONS, hasPermissions } from '../../shared/permissions.js';

const { generateDiversityReport } = initGenerateDiversityReport(config, firebase, db);
const { generateDiversityData } = initGenerateDiversityData(firebase, db);
Expand Down
14 changes: 7 additions & 7 deletions ...llableFunctions/generateHandoverReport.js → ...nctions/reports/generateHandoverReport.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import functions from 'firebase-functions';
import config from '../shared/config.js';
import { firebase, db, auth } from '../shared/admin.js';
import initGenerateHandoverReport from '../actions/exercises/generateHandoverReport.js';
import { getDocument } from '../shared/helpers.js';
import initLogEvent from '../actions/logs/logEvent.js';
import initServiceSettings from '../shared/serviceSettings.js';
import { PERMISSIONS, hasPermissions } from '../shared/permissions.js';
import config from '../../shared/config.js';
import { firebase, db, auth } from '../../shared/admin.js';
import initGenerateHandoverReport from '../../actions/exercises/generateHandoverReport.js';
import { getDocument } from '../../shared/helpers.js';
import initLogEvent from '../../actions/logs/logEvent.js';
import initServiceSettings from '../../shared/serviceSettings.js';
import { PERMISSIONS, hasPermissions } from '../../shared/permissions.js';

const { generateHandoverReport } = initGenerateHandoverReport(firebase, config, db);
const { logEvent } = initLogEvent(firebase, db, auth);
Expand Down
Loading
Loading