Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

virus scanning #531

Merged
merged 30 commits into from
Jul 6, 2021
Merged

virus scanning #531

merged 30 commits into from
Jul 6, 2021

Conversation

HalcyonJAC
Copy link
Contributor

No description provided.

HalcyonJAC added 21 commits April 27, 2021 16:12
@HalcyonJAC
after virus scanning, add a suffix to the filename to indicate the ou…
d6b9828 
…tcome and prevent downloads where necessary
@HalcyonJAC
virus scanning - tidy-up
23d1363
@HalcyonJAC
added scanFile callable function
b8f1b79
@HalcyonJAC
virus scanner - resolved warning about bodyParser being deprecated
494a03f
@HalcyonJAC
virus scanner - use one storage bucket for all files
dec7916
@HalcyonJAC
deleted redundant files
6dcca37
@HalcyonJAC
give the malware scanning service a name
17cf8f0
@HalcyonJAC
virus scanner - validate input (check file exists)
d3474b5
@HalcyonJAC
virus scanner - don't add suffix anymore
d330ba6
@HalcyonJAC
download to temp file and delete when done
e117ef5
@HalcyonJAC
improved logging
91afafd
@HalcyonJAC
bug fix - not finding bucket
b798f3d
@HalcyonJAC
tweaked logging
d670217
@HalcyonJAC
added technical notes
7b1c08d
@HalcyonJAC
don't allow infected files to be downloaded
27964b6
@HalcyonJAC
moved 'delete temp file' operation to a finally block
d35b47f
@HalcyonJAC
deteted AddSuffix function (redundant)
c2fca22
@HalcyonJAC
simplified control structure
1a2c932
@HalcyonJAC
request malware scan after a document has been uploaded to storage
2619510
@HalcyonJAC
improved logging of malware scanning web service
953fd32
@HalcyonJAC
bug fix - out of memory
1424efc
@HalcyonJAC HalcyonJAC requested a review from warrensearle April 29, 2021 15:46
@HalcyonJAC HalcyonJAC self-assigned this Apr 29, 2021
@HalcyonJAC HalcyonJAC force-pushed the feature/virus-scanning branch 2 times, most recently from d30cf8c to ea3dc9e Compare April 30, 2021 12:00
@warrensearle warrensearle marked this pull request as draft May 20, 2021 09:31
HalcyonJAC added 3 commits July 6, 2021 09:30
@HalcyonJAC
Merge branch 'develop' into feature/virus-scanning
28e08ca 
# Conflicts:
#	functions/index.js
#	package.json
#	storage/storage.rules
#	virus-scanning/package-lock.json
@HalcyonJAC
added rate limiter to virus scanning endpoint
72d976e
@HalcyonJAC
added deployment instructions for virus scanning app
7ea22ad
@HalcyonJAC HalcyonJAC marked this pull request as ready for review July 6, 2021 11:15
warrensearle
warrensearle approved these changes Jul 6, 2021
View reviewed changes
Copy link
Member

@warrensearle warrensearle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and thank you in particular for the README instructions 😄 👍

mbrookeswebdev
mbrookeswebdev approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@mbrookeswebdev mbrookeswebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@HalcyonJAC HalcyonJAC merged commit 8571bcc into develop Jul 6, 2021
@HalcyonJAC HalcyonJAC deleted the feature/virus-scanning branch July 6, 2021 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomlovesgithub tomlovesgithub tomlovesgithub approved these changes

@mbrookeswebdev mbrookeswebdev mbrookeswebdev approved these changes

@warrensearle warrensearle warrensearle approved these changes

Assignees

@HalcyonJAC HalcyonJAC

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HalcyonJAC @warrensearle @mbrookeswebdev @tomlovesgithub