Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#546 Bugfix: Should be able to initialise a QT #547

Merged
merged 1 commit into from
May 20, 2021
Merged

#546 Bugfix: Should be able to initialise a QT #547

merged 1 commit into from
May 20, 2021

Conversation

warrensearle
Copy link
Member

Closes #546

Callable function initialiseQualifyingTest was returning the following error:

Cannot use "undefined" as a Firestore value (found in field "qualifyingTest.isTieBreaker"

This PR fixes that.

HalcyonJAC
HalcyonJAC approved these changes May 20, 2021
View reviewed changes
Copy link
Contributor

@HalcyonJAC HalcyonJAC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@HalcyonJAC HalcyonJAC merged commit e695af0 into develop May 20, 2021
@HalcyonJAC HalcyonJAC deleted the bugfix/546-qt-initialise branch May 20, 2021 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HalcyonJAC HalcyonJAC HalcyonJAC approved these changes

@mbrookeswebdev mbrookeswebdev mbrookeswebdev approved these changes

@tomlovesgithub tomlovesgithub Awaiting requested review from tomlovesgithub

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should be able to initialise a Qualifying Test
3 participants
@warrensearle @mbrookeswebdev @HalcyonJAC