Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup GitHub Code Scanning #564

Merged
merged 1 commit into from
Jun 22, 2021
Merged

Setup GitHub Code Scanning #564

merged 1 commit into from
Jun 22, 2021

Conversation

HalcyonJAC
Copy link
Contributor

@HalcyonJAC HalcyonJAC commented May 21, 2021

Author checklist

  • Include primary ticket number in title - e.g. "Move uploaded references to Google Drive #123 New styling for widget" - and any additional tickets in description
  • Fill in the details below and delete as appropriate
  • Be proactive in getting your work approved 💪

What's included?

A script that enables GitHub Code Scanning to run on a schedule.

Who should test?

✅ Developers

How to test?

Once the code has been merged, GitHub should start scanning the main develop every day and alerting us when it finds vulnerabilities in code, i.e. code that could allow remote code injection attacks, unsanitised inputs to be maniuplated, etc.

Risk - how likely is this to impact other areas?

🟢 No risk - this is a self-contained piece of work

Additional context

Include screen grabs, notes etc.


PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

@lloback
Copy link
Contributor

lloback commented May 21, 2021

Please insert steps to test.

@HalcyonJAC
Copy link
Contributor Author

HalcyonJAC commented Jun 10, 2021

Please insert steps to test.

Hi Lee. Ok I have updated the PR (the template was missing) to describe what's going on a bit more. There aren't any steps to test as such for this PR though.

Copy link
Contributor

@lloback lloback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I said in another PR related to this, this is a really good idea. Well done!

Copy link
Member

@warrensearle warrensearle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Copy link
Contributor

@mbrookeswebdev mbrookeswebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@KateMJAC KateMJAC merged commit 55c132e into develop Jun 22, 2021
@KateMJAC KateMJAC deleted the enable-codeql-anlaysis branch June 22, 2021 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants