Small async changes to assessment request #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warrensearle
requested changes
Jul 6, 2021
There was a problem hiding this comment.
@tomlovesgithub can you walk me through these changes. I'm a little confused!
functions/actions/assessments.js
Outdated
|
|
||
| // get assessments | ||
| let assessmentsRef = db.collection('assessments') | ||
| let assessmentsRef = await db.collection('assessments') |
There was a problem hiding this comment.
Using an await here doesn't look right. We are constructing assessmentsRef in lines 289 - 301 and actually using it, with await, on line 303
tomlovesgithub
commented
Jul 6, 2021
functions/actions/assessments.js
Outdated
| return res; | ||
| }); | ||
|
|
||
| let result = await validateAssessorEmailAddresses(assessments).then((res) => { |
tomlovesgithub
commented
Jul 6, 2021
| @@ -301,6 +301,7 @@ module.exports = (config, firebase, db) => { | |||
| const assessments = await getDocuments(assessmentsRef); | |||
|
|
|||
| let result = validateAssessorEmailAddresses(assessments); | |||
|
|
|||
warrensearle
approved these changes
Jul 6, 2021
HalcyonJAC
approved these changes
Jul 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was unsure of where the function was failing, as there was no errors logged and the function was returning true.
I believe that these changes, specifically where noted below have fixed the issue, and testing between this branch and develop, confirms this.