-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#696 - scan existing files for viruses #710
Merged
HalcyonJAC
merged 9 commits into
develop
from
feature/696-scan-existing-files-for-viruses
May 17, 2022
Merged
#696 - scan existing files for viruses #710
HalcyonJAC
merged 9 commits into
develop
from
feature/696-scan-existing-files-for-viruses
May 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-isaac
approved these changes
May 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to sign off @HalcyonJAC and see demo at the end of week
warrensearle
approved these changes
May 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff, thank you 👍
tomlovesgithub
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Author checklist
What's included?
Several months ago a virus scanning module was developed to scan documents as they are uploaded to the Firebase bucket. Metadata is then added to scanned files to indicate whether a virus was found or not. Firebase storage files then prevent the file from being downloaded if it has been scanned and found to have a virus.
The above works fine however many files had already been uploaded to the JAC system before the above was deployed. This piece of development is to make something that can scan all existing files in the bucket.
IMPORTANT: Once testing has been done on develop, the Virus Scanning service on develop should be switched off, as each instance
Who should test?
✅ Product owner
✅ Developers
How to test?
scanAllFiles
endpoint in PostmanRisk - how likely is this to impact other areas?
🟢 No risk - this is a self-contained piece of work
Related permissions
Have permissions been considered for this functionality?
PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING