#947 New applications should include _sort field #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HalcyonJAC
approved these changes
Nov 10, 2023
warrensearle
deleted the
hotfix/947-new-applicationss-include-fullname-sort
branch
drieJAC
added a commit
that referenced
this pull request
Dec 7, 2023
drieJAC
added a commit
that referenced
this pull request
Dec 13, 2023
* Added callable function to create zenhub issue. Removed hook for onCreateBugReport and moved functionality into the callable function. Added screenshot link to ZH issue. Added permission for new callable function. * Update issue templates * Changed lord to lady (chief justice) (#962) * [ admin#1861 ] Processing applications improvements (#953) * [ admin#1861 ] Processing applications improvements * Add support for EMP tie-breaker * Fix tests * Bump version number to 1.71.0 * Support processing version 2 * Feature/Export commissioner conflicts (#957) * add commissioners to vacancy model * export to doc * add style * rename variable * Updated indexes (#964) * Added fullnameUC irrespective of whether there's any fullname set. (#966) * admin#1870 Shortlisting outcome MVP, admin#2191 Pre Selection Day tasks (#971) * [ admin#1870 ] Shortlisting outcome MVP * [ jac-uk/admin/issues/2190 ] Pre Selection Day task * WIP * Create candidateFormResponses * Rules for candidateForm responses * Firestore rules for candidateForm responses Add flag to applicationRecord for form status Add applicationId to form response * Update rules --------- Co-authored-by: drieJac <jac.drie@digitalteam.uk> * Feature/Admin#2170 Update Downloads in line with Application Form updates (#968) * update applicationConverter.js and lookup.js * Fix display of judicial experience and employment gaps in applicationConverter.js * Add _applicationVersion to mockExercise for legal exercises * update datetime format * tidy up * update wording * add details to panel pack * add details * Feature/Admin#2169 Update Reports in line with Application Form updates (#967) * update statutory consultation report * Add comments * rename variable * update datetime format * update header * update stat con report * fix if isOngoing exists * update datetime format of experience * fix employment gaps * Bump version number to 1.72.0 * [admin#2190] Create candidate form and fix date name change (#974) * Feature/admin 2192 (#973) * Add sendPreSelectionDayQuestionnaireNotifications function * tidy up * fix notification type * update submit * update email notification * Feature/Admin 2141 - Add Firestore indexes (#976) * update indexes * update firestore indexes * Prepopulate candidate availability dates * Fix lint error * Exclude weekends from candidate availability dates * Restore document function (#878) * restore document function * move file * Feature/Apply#1090 Update Firestore security rules (#978) * update firestore security rules * update task status in application * Fix restoreDocument warnings * Security rules for application updates via candidate forms --------- Co-authored-by: warrensearle <warren@precise-minds.co.uk> * admin#2141 Further updates to PSDQ backend (#980) * update firestore security rules * update task status in application * Fix restoreDocument warnings * Security rules for application updates via candidate forms * admin#2141 Further updates to PSDQ backend * Tidy --------- Co-authored-by: halcyonjac <halcyon@judicialappointments.digital> * #2091/self assessment document extraction (#975) * doc-extraction-function * wip * working proto * progress * tidy * merge * merge * merge * merge * merge * merge * discard changes in package.json * update package.json --------- Co-authored-by: halcyonjac <halcyon@judicialappointments.digital> --------- Co-authored-by: nickaddy <138654969+nickaddy@users.noreply.github.com> Co-authored-by: warrensearle <warren@precise-minds.co.uk> Co-authored-by: HalcyonJAC <79906532+HalcyonJAC@users.noreply.github.com> Co-authored-by: tomlovesgithub <44227249+tomlovesgithub@users.noreply.github.com> Co-authored-by: halcyonjac <halcyon@judicialappointments.digital>
drieJAC
added a commit
that referenced
this pull request
Dec 15, 2023
* Added callable function to create zenhub issue. Removed hook for onCreateBugReport and moved functionality into the callable function. Added screenshot link to ZH issue. Added permission for new callable function. * Update issue templates * Changed lord to lady (chief justice) (#962) * [ admin#1861 ] Processing applications improvements (#953) * [ admin#1861 ] Processing applications improvements * Add support for EMP tie-breaker * Fix tests * Bump version number to 1.71.0 * Support processing version 2 * Feature/Export commissioner conflicts (#957) * add commissioners to vacancy model * export to doc * add style * rename variable * Updated indexes (#964) * Added fullnameUC irrespective of whether there's any fullname set. (#966) * admin#1870 Shortlisting outcome MVP, admin#2191 Pre Selection Day tasks (#971) * [ admin#1870 ] Shortlisting outcome MVP * [ jac-uk/admin/issues/2190 ] Pre Selection Day task * WIP * Create candidateFormResponses * Rules for candidateForm responses * Firestore rules for candidateForm responses Add flag to applicationRecord for form status Add applicationId to form response * Update rules --------- Co-authored-by: drieJac <jac.drie@digitalteam.uk> * Feature/Admin#2170 Update Downloads in line with Application Form updates (#968) * update applicationConverter.js and lookup.js * Fix display of judicial experience and employment gaps in applicationConverter.js * Add _applicationVersion to mockExercise for legal exercises * update datetime format * tidy up * update wording * add details to panel pack * add details * Feature/Admin#2169 Update Reports in line with Application Form updates (#967) * update statutory consultation report * Add comments * rename variable * update datetime format * update header * update stat con report * fix if isOngoing exists * update datetime format of experience * fix employment gaps * Bump version number to 1.72.0 * [admin#2190] Create candidate form and fix date name change (#974) * Feature/admin 2192 (#973) * Add sendPreSelectionDayQuestionnaireNotifications function * tidy up * fix notification type * update submit * update email notification * Feature/Admin 2141 - Add Firestore indexes (#976) * update indexes * update firestore indexes * Prepopulate candidate availability dates * Fix lint error * Exclude weekends from candidate availability dates * Restore document function (#878) * restore document function * move file * Feature/Apply#1090 Update Firestore security rules (#978) * update firestore security rules * update task status in application * Fix restoreDocument warnings * Security rules for application updates via candidate forms --------- Co-authored-by: warrensearle <warren@precise-minds.co.uk> * admin#2141 Further updates to PSDQ backend (#980) * update firestore security rules * update task status in application * Fix restoreDocument warnings * Security rules for application updates via candidate forms * admin#2141 Further updates to PSDQ backend * Tidy --------- Co-authored-by: halcyonjac <halcyon@judicialappointments.digital> * #2091/self assessment document extraction (#975) * doc-extraction-function * wip * working proto * progress * tidy * merge * merge * merge * merge * merge * merge * discard changes in package.json * update package.json --------- Co-authored-by: halcyonjac <halcyon@judicialappointments.digital> --------- Co-authored-by: nickaddy <138654969+nickaddy@users.noreply.github.com> Co-authored-by: warrensearle <warren@precise-minds.co.uk> Co-authored-by: HalcyonJAC <79906532+HalcyonJAC@users.noreply.github.com> Co-authored-by: tomlovesgithub <44227249+tomlovesgithub@users.noreply.github.com> Co-authored-by: halcyonjac <halcyon@judicialappointments.digital>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include sort field for fullnameUC even if the fullname isnt set.
This should help to fix issue where the respective exercise counts (based on the state) are incorrect because the application doesnt have a name yet.
Closes #947