Skip to content
This repository has been archived by the owner on May 18, 2020. It is now read-only.

Jaeger Version++ && Version documentation #89

Merged
merged 5 commits into from
Jun 19, 2018
Merged

Jaeger Version++ && Version documentation #89

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dde3323
Jaeger Version++ && Version documentation
Aergonus May 22, 2018
6687919
Clean up Docker Tag Advice
Aergonus May 30, 2018
57ec89f
(version++)++
Aergonus Jun 18, 2018
b105384
Move image versions to README
Aergonus Jun 18, 2018
e66bbba
Update docker image advice
Aergonus Jun 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,10 @@ kubectl run jaeger-spark-dependencies --schedule="55 23 * * *" --env="STORAGE=ca

If you want to run the job only once and immediately then remove scheduled flag.

## Docker Versions
The jaeger project automatically creates new docker images with versions that mirror the release number. Feel free to pick the latest release.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/jaeger/Jaeger

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/docker/Docker

> A general k8 tip; it's recommended that you do not use `:latest` in production but rather pin the latest version.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k8? Did you mean Kubernetes (k8s)? I think this tip is more general than that, so:

Docker pro-tip: do not use :latest in production, but rather, pin it to the latest release

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct the tags are parsed by docker, but seeing as this is a kubernetes repo and most people are deploying jaeger with kubernetes, tagging this as a kubernetes/deployment related tip would be less confusing.


## Helm support
A curated [Chart for Kubernetes Helm](https://github.com/kubernetes/charts/tree/master/incubator/jaeger) that adds all components required to run Jaeger.

Expand Down
10 changes: 7 additions & 3 deletions jaeger-production-template.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@
# the License.
#

#
# Check https://github.com/jaegertracing/jaeger/releases for the latest version to use
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please remove this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should rather link to dockerhub but I think everybody knows what registry it is using and where to find more info

#

apiVersion: v1
kind: List
items:
Expand All @@ -33,7 +37,7 @@ items:
jaeger-infra: collector-pod
spec:
containers:
- image: jaegertracing/jaeger-collector:1.2
- image: jaegertracing/jaeger-collector:1.4.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The newest is 1.5.0

name: jaeger-collector
command:
- "/go/bin/collector-linux"
Expand Down Expand Up @@ -119,7 +123,7 @@ items:
jaeger-infra: query-pod
spec:
containers:
- image: jaegertracing/jaeger-query:1.2
- image: jaegertracing/jaeger-query:1.4.1
name: jaeger-query
command:
- "/go/bin/query-linux"
Expand Down Expand Up @@ -179,7 +183,7 @@ items:
spec:
containers:
- name: agent-instance
image: jaegertracing/jaeger-agent:1.2
image: jaegertracing/jaeger-agent:1.4.1
command:
- "/go/bin/agent-linux"
- "--config-file=/conf/agent.yaml"
Expand Down
3 changes: 2 additions & 1 deletion production/cassandra.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,8 @@ items:
spec:
containers:
- name: jaeger-cassandra-schema
image: jaegertracing/jaeger-cassandra-schema:1.2
image: jaegertracing/jaeger-cassandra-schema:1.4.1
# Check https://github.com/jaegertracing/jaeger/releases for the latest version
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment is not needed

env:
- name: MODE
value: "prod"
Expand Down