Jaeger Version++ && Version documentation #89
Conversation
|
|
Heh... I see. DCO pulls from git config. |
Similar to jaegertracing#70, addresses jaegertracing#88 Signed-off-by: Victor Lei <KLEI22@bloomberg.net>
I don't think DCO has access to your git config. I am not sure how in that ticket the Author is different from the sign-off, wouldn't they both come from git config? Personally I recommend using your full name in the GitHub profile, I think it takes care of the issue. It's not like your full name is a secret if you're putting it in the commit signature anyway. |
README.md
Outdated
| @@ -147,6 +147,10 @@ kubectl run jaeger-spark-dependencies --schedule="55 23 * * *" --env="STORAGE=ca | |||
|
|
|||
| If you want to run the job only once and immediately then remove scheduled flag. | |||
|
|
|||
| ## Docker Versions | |||
| The jaeger project automatically creates new docker images with versions that mirror the release number. Feel free to pick the latest release. | |||
README.md
Outdated
| @@ -147,6 +147,10 @@ kubectl run jaeger-spark-dependencies --schedule="55 23 * * *" --env="STORAGE=ca | |||
|
|
|||
| If you want to run the job only once and immediately then remove scheduled flag. | |||
|
|
|||
| ## Docker Versions | |||
| The jaeger project automatically creates new docker images with versions that mirror the release number. Feel free to pick the latest release. | |||
| > A general k8 tip; it's recommended that you do not use `:latest` in production but rather pin the latest version. | |||
There was a problem hiding this comment.
k8? Did you mean Kubernetes (k8s)? I think this tip is more general than that, so:
Docker pro-tip: do not use
:latestin production, but rather, pin it to the latest release
There was a problem hiding this comment.
Correct the tags are parsed by docker, but seeing as this is a kubernetes repo and most people are deploying jaeger with kubernetes, tagging this as a kubernetes/deployment related tip would be less confusing.
Aergonus
force-pushed
the
version++
branch
2 times, most recently
from
8d3e4ed to
4f27723
Compare
|
ping! |
Address PR comments and run CI tests again Signed-off-by: Victor Lei <klei22@bloomberg.net>
There was a problem hiding this comment.
@Spellchaser thanks for the PR!
I don't think that readme section about tags is necessary as we use pinned versions.
jaeger-production-template.yml
Outdated
| @@ -12,6 +12,10 @@ | |||
| # the License. | |||
| # | |||
|
|
|||
| # | |||
| # Check https://github.com/jaegertracing/jaeger/releases for the latest version to use | |||
There was a problem hiding this comment.
can you please remove this?
There was a problem hiding this comment.
This should rather link to dockerhub but I think everybody knows what registry it is using and where to find more info
jaeger-production-template.yml
Outdated
| @@ -33,7 +37,7 @@ items: | |||
| jaeger-infra: collector-pod | |||
| spec: | |||
| containers: | |||
| - image: jaegertracing/jaeger-collector:1.2 | |||
| - image: jaegertracing/jaeger-collector:1.4.1 | |||
production/cassandra.yml
Outdated
| @@ -120,7 +120,8 @@ items: | |||
| spec: | |||
| containers: | |||
| - name: jaeger-cassandra-schema | |||
| image: jaegertracing/jaeger-cassandra-schema:1.2 | |||
| image: jaegertracing/jaeger-cassandra-schema:1.4.1 | |||
| # Check https://github.com/jaegertracing/jaeger/releases for the latest version | |||
|
Right so the pinned versions here are seldom updated. For any new user coming to the project, it's better to at least have a comment warning them that this may not be the latest version. I spent more time than I'd like to admit on trying to get |
Signed-off-by: Victor Lei <klei22@bloomberg.net>
I don't see such a comment in the readme. It would be better to add a sentence to Development setup about using latest and somewhere to production setup about using pinned version. |
Signed-off-by: Victor Lei <klei22@bloomberg.net>
|
The process for determining what version is useable for production seems to be the latest release for jaeger. Are you relying on the CI jobs to test the new versions for production? |
|
The pinned version is used to not accidentally break people on new releases. I wanted also tag this repo to version templates too as there can be changes too. |
|
Uhhh lemme change the README |
|
np I will wait |
Don't tell people "Feel free to use the latest version" Signed-off-by: Victor Lei <klei22@bloomberg.net>
|
I think that's valid english :) |
|
@Spellchaser thanks |
Similar to #70, addresses #88
Signed-off-by: Victor Lei KLEI22@bloomberg.net