-
Notifications
You must be signed in to change notification settings - Fork 156
Conversation
https://www.jaegertracing.io/docs/deployment/#agent Signed-off-by: Victor Lei <klei22@bloomberg.net>
command: | ||
- "/go/bin/agent-linux" | ||
- "--collector.host-port=jaeger-collector.jaeger-infra.svc:14267" | ||
``` | ||
|
||
The Jaeger Agent will then be available to your application at `localhost:5775`/`localhost:6831`/`localhost:6832`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this should be changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I believe so.
Addresses #91 |
Thank you for this PR! It looks good to me, but Travis is failing due to:
You can fix it by running |
... doesn't work behind a proxy Signed-off-by: Victor Lei <klei22@bloomberg.net>
It's quite ridiculous to me that it's up to an external contributor to keep the license up to date... Not to mention I'm working behind proxies I don't control so mvnw doesn't work. Travis jobs have been broken since #89 at least |
I feel your pain!
This is not always the case, but it's the first time this file was changed this year, so, the license checker requires this update.
Indeed, just wanted to avoid one more reason for it to be broken ;-) @jkandasa, @kevinearls, do you know why the CI tests are broken? |
Looks like the tests are failing intermittently. |
c* sometimes fails. it has to be manually restarted |
Our integration tests are really far from being reliable... I had also to restart ES's job. |
I'll push a no-op update to the other PR so it can rerun the CI tests |
https://www.jaegertracing.io/docs/deployment/#agent
Signed-off-by: Victor Lei klei22@bloomberg.net