Skip to content
This repository has been archived by the owner on May 18, 2020. It is now read-only.

Add HTTP Port 5778 #92

Merged
merged 2 commits into from
Jun 18, 2018
Merged

Add HTTP Port 5778 #92

merged 2 commits into from
Jun 18, 2018

Conversation

Aergonus
Copy link
Contributor

https://www.jaegertracing.io/docs/deployment/#agent

$ grep -r 5775 *
all-in-one/jaeger-all-in-one-template.yml:                - containerPort: 5775
all-in-one/jaeger-all-in-one-template.yml:      port: 5775
all-in-one/jaeger-all-in-one-template.yml:      targetPort: 5775
jaeger-production-template.yml:          - containerPort: 5775
README.md:          - containerPort: 5775
README.md:The Jaeger Agent will then be available to your application at `localhost:5775`/`localhost:6831`/`localhost:6832`/`localhost:5778`.
$ grep -r 5778 *
all-in-one/jaeger-all-in-one-template.yml:                - containerPort: 5778
all-in-one/jaeger-all-in-one-template.yml:      port: 5778
all-in-one/jaeger-all-in-one-template.yml:      targetPort: 5778
jaeger-production-template.yml:          - containerPort: 5778
README.md:          - containerPort: 5778
README.md:The Jaeger Agent will then be available to your application at `localhost:5775`/`localhost:6831`/`localhost:6832`/`localhost:5778`.

Signed-off-by: Victor Lei klei22@bloomberg.net

https://www.jaegertracing.io/docs/deployment/#agent

Signed-off-by: Victor Lei <klei22@bloomberg.net>
command:
- "/go/bin/agent-linux"
- "--collector.host-port=jaeger-collector.jaeger-infra.svc:14267"
```

The Jaeger Agent will then be available to your application at `localhost:5775`/`localhost:6831`/`localhost:6832`.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this should be changed

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I believe so.

@Aergonus
Copy link
Contributor Author

Addresses #91

@jpkrohling
Copy link
Collaborator

jpkrohling commented Jun 13, 2018

Thank you for this PR! It looks good to me, but Travis is failing due to:

[WARNING] Missing header in: /home/travis/build/jaegertracing/jaeger-kubernetes/all-in-one/jaeger-all-in-one-template.yml

You can fix it by running ./mvnw license:format. Once this is fixed, I'll merge this PR.

... doesn't work behind a proxy

Signed-off-by: Victor Lei <klei22@bloomberg.net>
@Aergonus
Copy link
Contributor Author

It's quite ridiculous to me that it's up to an external contributor to keep the license up to date... Not to mention I'm working behind proxies I don't control so mvnw doesn't work.

Travis jobs have been broken since #89 at least

@jpkrohling
Copy link
Collaborator

I feel your pain!

It's quite ridiculous to me that it's up to an external contributor to keep the license up to date

This is not always the case, but it's the first time this file was changed this year, so, the license checker requires this update.

Travis jobs have been broken since #89 at least

Indeed, just wanted to avoid one more reason for it to be broken ;-)

@jkandasa, @kevinearls, do you know why the CI tests are broken?

@jpkrohling
Copy link
Collaborator

Looks like the tests are failing intermittently.

@jpkrohling jpkrohling merged commit 1160529 into jaegertracing:master Jun 18, 2018
@pavolloffay
Copy link
Member

c* sometimes fails. it has to be manually restarted

@jpkrohling
Copy link
Collaborator

jpkrohling commented Jun 18, 2018

Our integration tests are really far from being reliable... I had also to restart ES's job.

@Aergonus Aergonus deleted the agentport branch June 18, 2018 20:44
@Aergonus
Copy link
Contributor Author

I'll push a no-op update to the other PR so it can rerun the CI tests

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants