-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump antd from 3.26.20 to 4.24.13 #1636
Conversation
2a0ac9a
to
edfcf5d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm interested in fixing issue upgrade antd #1636. I've reviewed the changelogs and identified the issue and made some progress fixing it.
I've had a painful relation with AntD in the past, but I also gained a ton of experience working with it. This makes me uniquely qualified to fix this issue
I'm happy to collaborate or take the lead on fixing this issue. Please let me know if you have any questions.
hi @bupd
can you elaborate?
Feel free to propose a PR. It would be good to know the scope / complexity of this upgrade, is it going to require a lot of code changes, or some cosmetic fixes? Could it be done incrementally? |
I'm happy to elaborate on my previous comment When I first started using AntD, I didn't have much experience with React or component-based frameworks. I tried to learn AntD by trial and error, and I made a lot of mistakes along the way. I also didn't have a good understanding of the AntD codebase, so I found it difficult to debug problems. However, I learned a lot from my mistakes, and I eventually became proficient in using AntD. I also gained a lot of experience with tables and designing entire websites with AntD. I believe that my experience with AntD, both positive and negative, will make me a valuable asset to the team working on this issue. I'm confident that I can fix the issue in a timely and efficient manner
The AntD upgrade issue requires a substantial amount of code, as it needs to be fixed in several different files throughout the codebase. The most critical part of the upgrade is the icons, which need to be updated to use the new @antdesign/icons package. Other components will also need to be updated, but these changes can be made incrementally. I agree that the upgrade can be done incrementally. I would start by fixing the icons, which are the most critical part of the upgrade. I would then move on to fixing the Input and some other components, one by one. I would use an incremental approach to ensure that nothing breaks, and I would make sure to test the code thoroughly at each step. I'm available to work full-time on this issue, and I'm committed to seeing it through to completion. I'm also a quick learner and I'm familiar with the AntD codebase. I would be happy to propose a PR for this issue. I would also be happy to collaborate with others on the team to fix this issue. I believe that working together, we can quickly and efficiently fix this issue and make AntD even better. I don't know why but I am pretty excited!! 😀 |
37ce2bb
to
ac187c0
Compare
## Which problem is this PR solving? - Part of #1636 ## Description of the changes - Changing icons from v3 to v4 ## How was this change tested? - Tested locally everything seems good ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [ ] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: bupd <bupdprasanth@gmail.com>
## Which problem is this PR solving? - Resolves Icons part of #1636 ## Description of the changes - Completely upgraded the antd Icons to V4 - Modified tests to suit the V4 ## How was this change tested? - All the changes were tested with all the required tests - Ran the tests locally and passed ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: bupd <bupdprasanth@gmail.com>
@dependabot rebase |
bf972f1
to
2d0ad0c
Compare
6ed67a8
to
cfc98b8
Compare
cfc98b8
to
5d71ffd
Compare
5d71ffd
to
85fa7ae
Compare
@dependabot rebase |
Bumps [antd](https://github.com/ant-design/ant-design) from 3.26.20 to 4.24.13. - [Release notes](https://github.com/ant-design/ant-design/releases) - [Changelog](https://github.com/ant-design/ant-design/blob/4.24.13/CHANGELOG.en-US.md) - [Commits](ant-design/ant-design@3.26.20...4.24.13) --- updated-dependencies: - dependency-name: antd dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
85fa7ae
to
4b03a6b
Compare
@dependabot rebase |
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Rebasing might not happen immediately, so don't worry if this takes some time.
Note: if you make any changes to this PR yourself, they will take precedence over the rebase.
Bumps antd from 3.26.20 to 4.24.13.
Release notes
Sourced from antd's releases.
... (truncated)
Changelog
Sourced from antd's changelog.
... (truncated)
Commits
0b6920b
docs: 4.24.13 changelog (#43985)a0cf986
fix: getCurrentLink not trigger when scroll (#43917)2b43f73
feat:@ant-design/react-slick
upgrade (#39634) (#43806)c501af9
fix: fix lint for 4.x (#43807)53ce254
fix: select check remove icon align (#43667)f92abac
demo: fixed 4.x Modal render (#43696)2c6d565
fix: rethrow error in ActionButton's onOk callback (#43536)e59016b
fix:ConfigProvider
form validateMessages nesting error (#43480)f57c688
style: Checkbox should use@border-radius-sm
(#43356)2afbf67
docs: 4.24.12 changelog (#43293)You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually