Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump antd from 3.26.20 to 4.24.13 #1636

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 3, 2023

⚠️ Dependabot is rebasing this PR ⚠️

Rebasing might not happen immediately, so don't worry if this takes some time.

Note: if you make any changes to this PR yourself, they will take precedence over the rebase.


Bumps antd from 3.26.20 to 4.24.13.

Release notes

Sourced from antd's releases.

4.24.13


  • 🐞 修复 Anchor 在滚动时无法触发 getCurrentAnchor 的问题。#43917
  • 🛠 Carousel 移除 lodash 依赖。2b43f73 @​taozhou-glean
  • 🐞 修复 Select 选中时移除图标未对齐错误。#43667 @​Wxh16144
  • 🐞 让用户能够处理 Modal 中 onOk 回调中的 Promise 异常。#43536 @​maroon1
  • 🐞 修复 ConfigProvider 表单校验信息 validateMessages 嵌套使用错误。#43480 @​Wxh16144
  • 🐞 修复 variable.less 没有同步改动 @checkbox-border-radius 导致变量表现不一致的问题。#43356

4.24.12

  • 🐞 Fix Form submit trigger wrong onFieldsChange event even all the fields do not config rules. #43292
  • 🐞 Fix Form.List nested Form event bubble not correct. #43292

  • 🐞 修复 Form 在提交时,字段没有配置 rules 时仍会错误触发 onFieldsChange 事件的问题。#43292
  • 🐞 修复 Form 嵌套 Form.List 嵌套 Form 的场景下,事件触发不正确的问题。#43292

4.24.11

  • 🆕 Drawer panel support event listener. #42712 @​kiner-tang
  • 🐞 Fix Upload onChange sometime not sync when in React 18. #43200
  • 🐞 Fix Notification cannot hide close icon by closeIcon={null}. #42791
  • 🐞 Fix Drawer id was passed in incorrectly, and now is always added to the popup panel. #43124 @​MuxinFeng
  • 🐞 Fix InputNumber with prefix abnormal height under Form.Item of hasFeedBack. #43048
  • 🐞 Fix Popover with getPopupContainer sometime makes width too narrow. #42697
  • 🐞 Fix Select will display the letter A under some circumstances. #42654 @​tchen-l
  • 🐞 Fix ConfigProvider that import useless modules from rc-field-form when importing FormProvider . #42502 @​BanShan-Alec
  • 🐞 Fix Popconfirm trigger onVisibleChange twice. #42351
  • 🐞 Fix Form onFieldsChange missing validating status change. #42263
  • 🐞 Fix Popover that display empty div when title and content is null. 19f8505 @​MaHui
  • 🐞 Fix Upload disabled logic. #42143 @​Wxh16144
  • 🐞 Fix RangePicker wrong panel position under some circumstances. #43179 @​cooljser
  • 🐞 Fix ConfigProvider makes Form component in the bundle even not use it. #43207 @​yoyo837
  • 💄 Optimize Spin style to keep height of container the same as child element. #42163 @​cheapCoder

  • 🆕 Drawer 组件面板支持事件监听。#42712 @​kiner-tang
  • 🐞 修复 Upload 在 React 18 下 onChange 有时数据不正确的问题。#43200
  • 🐞 修复 Notification 设置 closeIcon={null} 时关闭图标没有消失的问题。#42791
  • 🐞 修复 Drawer id 传入位置不正确的问题,现在始终会添加至弹出面板上。#43124 @​MuxinFeng
  • 🐞 修复 InputNumber 带有 prefix 时在 Form.Item hasFeedBack 内高度异常的问题。#43048
  • 🐞 修复 Popover 设置 getPopupContainer 后,某些时候宽度会过窄的问题。#42697
  • 🐞 修复 Select 在某些情况下会显示字母 A 的问题。#42654 @​tchen-l
  • 🐞 修复 ConfigProvider 引入 FormProvider 时,错误引入 'rc-field-form' 其他的无关依赖的问题。#42502 @​BanShan-Alec
  • 🐞 修复 Popconfirm 的 onVisibleChange 会重复触发的问题。#42351
  • 🐞 修复 Form onFieldsChange 丢失一次 validating 状态变更的更新事件。#42263
  • 🐞 修复 Popover 组件当 titlecontent 都为空时展示空气泡的问题19f8505 @​MaHui

... (truncated)

Changelog

Sourced from antd's changelog.

4.24.13

2023-08-03

4.24.12

2023-06-30

  • 🐞 Fix Form submit trigger wrong onFieldsChange event even all the fields do not config rules. #43292
  • 🐞 Fix Form.List nested Form event bubble not correct. #43292

4.24.11

2023-06-27

  • 🆕 Drawer panel support event listener. #42712 @​kiner-tang
  • 🐞 Fix Upload onChange sometime not sync when in React 18. #43200
  • 🐞 Fix Notification cannot hide close icon by closeIcon={null}. #42791
  • 🐞 Fix Drawer id was passed in incorrectly, and now is always added to the popup panel. #43124 @​MuxinFeng
  • 🐞 Fix InputNumber with prefix abnormal height under Form.Item of hasFeedBack. #43048
  • 🐞 Fix Popover with getPopupContainer sometime makes width too narrow. #42697
  • 🐞 Fix Select will display the letter A under some circumstances. #42654 @​tchen-l
  • 🐞 Fix ConfigProvider that import useless modules from rc-field-form when importing FormProvider . #42502 @​BanShan-Alec
  • 🐞 Fix Popconfirm trigger onVisibleChange twice. #42351
  • 🐞 Fix Form onFieldsChange missing validating status change. #42263
  • 🐞 Fix Popover that display empty div when title and content is null. 19f8505 @​MaHui
  • 🐞 Fix Upload disabled logic. #42143 @​Wxh16144
  • 🐞 Fix RangePicker wrong panel position under some circumstances. #43179 @​cooljser
  • 🐞 Fix ConfigProvider makes Form component in the bundle even not use it. #43207 @​yoyo837
  • 💄 Optimize Spin style to keep height of container the same as child element. #42163 @​cheapCoder

4.24.10

2023-05-04

  • 🐞 Fix version always shows 5.2.2. #42101
  • 🐞 Fix Popover width collapse when show on the screen edge. #41953

4.24.9

2023-04-19

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually

@dependabot dependabot bot added dependencies javascript Pull requests that update Javascript code labels Aug 3, 2023
@dependabot dependabot bot requested a review from tiffon August 3, 2023 12:24
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/antd-4.24.13 branch 3 times, most recently from 2a0ac9a to edfcf5d Compare August 11, 2023 12:20
Copy link
Contributor

@bupd bupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm interested in fixing issue upgrade antd #1636. I've reviewed the changelogs and identified the issue and made some progress fixing it.

I've had a painful relation with AntD in the past, but I also gained a ton of experience working with it. This makes me uniquely qualified to fix this issue

I'm happy to collaborate or take the lead on fixing this issue. Please let me know if you have any questions.

@yurishkuro
Copy link
Member

hi @bupd

I've had a painful relation with AntD in the past

can you elaborate?

I'm happy to collaborate or take the lead on fixing this issue.

Feel free to propose a PR. It would be good to know the scope / complexity of this upgrade, is it going to require a lot of code changes, or some cosmetic fixes? Could it be done incrementally?

@bupd
Copy link
Contributor

bupd commented Aug 12, 2023

can you elaborate?

I'm happy to elaborate on my previous comment

When I first started using AntD, I didn't have much experience with React or component-based frameworks. I tried to learn AntD by trial and error, and I made a lot of mistakes along the way. I also didn't have a good understanding of the AntD codebase, so I found it difficult to debug problems.

However, I learned a lot from my mistakes, and I eventually became proficient in using AntD. I also gained a lot of experience with tables and designing entire websites with AntD.

I believe that my experience with AntD, both positive and negative, will make me a valuable asset to the team working on this issue. I'm confident that I can fix the issue in a timely and efficient manner

complexity of this upgrade

The AntD upgrade issue requires a substantial amount of code, as it needs to be fixed in several different files throughout the codebase. The most critical part of the upgrade is the icons, which need to be updated to use the new @antdesign/icons package. Other components will also need to be updated, but these changes can be made incrementally.

I agree that the upgrade can be done incrementally. I would start by fixing the icons, which are the most critical part of the upgrade. I would then move on to fixing the Input and some other components, one by one. I would use an incremental approach to ensure that nothing breaks, and I would make sure to test the code thoroughly at each step.

I'm available to work full-time on this issue, and I'm committed to seeing it through to completion. I'm also a quick learner and I'm familiar with the AntD codebase.

I would be happy to propose a PR for this issue.

I would also be happy to collaborate with others on the team to fix this issue. I believe that working together, we can quickly and efficiently fix this issue and make AntD even better.

I don't know why but I am pretty excited!! 😀

@bupd bupd mentioned this pull request Aug 12, 2023
4 tasks
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/antd-4.24.13 branch 5 times, most recently from 37ce2bb to ac187c0 Compare August 18, 2023 12:20
@bupd bupd mentioned this pull request Aug 18, 2023
4 tasks
yurishkuro pushed a commit that referenced this pull request Aug 20, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
## Which problem is this PR solving?
- Part of #1636 
## Description of the changes
- Changing icons from v3 to v4

## How was this change tested?
- Tested locally everything seems good

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [ ] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

---------

Signed-off-by: bupd <bupdprasanth@gmail.com>
@bupd bupd mentioned this pull request Aug 20, 2023
4 tasks
yurishkuro pushed a commit that referenced this pull request Aug 20, 2023
## Which problem is this PR solving?
- Resolves Icons part of #1636

## Description of the changes
- Completely upgraded the antd Icons to V4
- Modified tests to suit the V4 

## How was this change tested?
- All the changes were tested with all the required tests
- Ran the tests locally and passed

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

---------

Signed-off-by: bupd <bupdprasanth@gmail.com>
@yurishkuro
Copy link
Member

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/antd-4.24.13 branch 2 times, most recently from bf972f1 to 2d0ad0c Compare August 21, 2023 12:34
@yurishkuro yurishkuro mentioned this pull request Aug 21, 2023
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/antd-4.24.13 branch 2 times, most recently from 6ed67a8 to cfc98b8 Compare August 23, 2023 12:34
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/antd-4.24.13 branch from cfc98b8 to 5d71ffd Compare August 25, 2023 12:25
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/antd-4.24.13 branch from 5d71ffd to 85fa7ae Compare August 28, 2023 12:31
@yurishkuro
Copy link
Member

@dependabot rebase

@yurishkuro yurishkuro mentioned this pull request Sep 2, 2023
4 tasks
Bumps [antd](https://github.com/ant-design/ant-design) from 3.26.20 to 4.24.13.
- [Release notes](https://github.com/ant-design/ant-design/releases)
- [Changelog](https://github.com/ant-design/ant-design/blob/4.24.13/CHANGELOG.en-US.md)
- [Commits](ant-design/ant-design@3.26.20...4.24.13)

---
updated-dependencies:
- dependency-name: antd
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/antd-4.24.13 branch from 85fa7ae to 4b03a6b Compare September 2, 2023 16:00
@yurishkuro
Copy link
Member

@dependabot rebase

@yurishkuro yurishkuro closed this Sep 4, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 4, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/antd-4.24.13 branch September 4, 2023 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants