Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump antd from 3.26.20 to 4.24.13 #1667

Closed
wants to merge 3 commits into from

Conversation

bupd
Copy link
Contributor

@bupd bupd commented Aug 12, 2023

Which problem is this PR solving?

Description of the changes

  • Upgraded @types/react to work with antd v4
  • Upgrading antd to v4

How was this change tested?

  • By running the required tests

Checklist

Signed-off-by: bupd <bupdprasanth@gmail.com>
@yurishkuro
Copy link
Member

What is the purpose of this PR? We already have the bump attempted by dependabot and already know that it's not passing CI -- #1636

bupd and others added 2 commits August 13, 2023 04:21
@bupd
Copy link
Contributor Author

bupd commented Aug 14, 2023

Hi @yurishkuro,

I've finished upgrading antd icons to v4. I'm now working on modifying the test cases to support the new version.

Once I've finished and confirmed that the tests are passing, I'll push the changes to GitHub and ping you for review.

@yurishkuro
Copy link
Member

@bupd I strongly advise accumulating very large PR. From what I understand, icons changes can already be applied against antd 3.x, so why not submit small PRs incrementally?

@mszabo-wikia
Copy link
Contributor

FYI I have some unfinished prior art over at #1261 - feel free to take a look in case you might find something useful.

@yurishkuro
Copy link
Member

I'll close this in favor of #1636

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants