Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add span format tag for each span #1490

Closed
guo0693 opened this issue Apr 24, 2019 · 0 comments · Fixed by #1493
Closed

Add span format tag for each span #1490

guo0693 opened this issue Apr 24, 2019 · 0 comments · Fixed by #1493

Comments

@guo0693
Copy link
Contributor

guo0693 commented Apr 24, 2019 •
edited
Loading

Requirement - what kind of business use case are you trying to solve?

We want to make sure our internal users of jaeger always use the latest jaeger format (thrift-"jaeger", grpc-"proto")to emit spans.

We have flink job to analysis all the spans coming into kafka, and one of the analysis could be SpanFormatCheck, if jaeger collector always embed a span format check, we can use that to tell users that your format is legacy or not.

Problem - what in Jaeger blocks you from solving the requirement?

Currently jaeger span does not contain information regarding what kind of format the span is: zipkin or jaeger.

Proposal - what do you suggest to solve the problem or improve the existing situation?

Having jaeger collector embed internal.span.format tag with value to be "zipkin"/"jaeger"/"proto" when converting those format to domain object.

Any open questions to address
@guo0693 guo0693 mentioned this issue Apr 24, 2019
Merged
@pavolloffay pavolloffay mentioned this issue Oct 9, 2019
Closed
arajkumar added a commit to arajkumar/promscale_extension that referenced this issue Aug 24, 2022
@arajkumar
Add telemetry event to find ingested jaeger span types
7767f96 
This commit adds a telemetry event named `promscale_traces_jaeger_span_types` to find types of jaeger spans ingested into promscale.

According to [1], Trace spans processed by Jaeger collector will have an internal attribute named 'internal.span.format' with one of the values 'jaeger|zipkin|proto|otlp|unknown'[2]. We can use this to infer whether promscale's gRPC remote storage implementation has been used or not.

[1] jaegertracing/jaeger#1490
[2] https://github.com/jaegertracing/jaeger/blob/b7088238c017e5a54896efbf5ed38959e885e0c5/cmd/collector/app/processor/interface.go#L56-L67

Fixes timescale/promscale#1548

Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>
arajkumar added a commit to arajkumar/promscale_extension that referenced this issue Aug 24, 2022
@arajkumar
Add telemetry event to find ingested jaeger span types
44191a5 
This commit adds a telemetry event named `promscale_traces_jaeger_span_types` to find types of jaeger spans ingested into promscale.

According to [1], Trace spans processed by Jaeger collector will have an internal attribute named 'internal.span.format' with one of the values 'jaeger|zipkin|proto|otlp|unknown'[2]. We can use this to infer whether promscale's gRPC remote storage implementation has been used or not.

[1] jaegertracing/jaeger#1490
[2] https://github.com/jaegertracing/jaeger/blob/b7088238c017e5a54896efbf5ed38959e885e0c5/cmd/collector/app/processor/interface.go#L56-L67

Fixes timescale/promscale#1548

Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add span format tag for jaeger-collector guo0693/jaeger
1 participant
@guo0693