how to remove internal.span.format="jaeger"

[zheyiyi]

In the jaeger Ui, the tag include internal.span.format ="jaeger", is it possible to remove it? Where is the place it is added

[vprithvi]

What issue is this tag causing for you?

[zheyiyi]

No issue. just want to remove it from tag. it is useless for my appliction Prithvi Raj <notifications@github.com> 于2019年10月4日周五 上午11:09写道：

…

What issue is this tag causing for you? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1830?email_source=notifications&email_token=ADBVK72LDYSGWDSIRTJKLQ3QM5MCBA5CNFSM4I5Q5TWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAL6R2A#issuecomment-538437864>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADBVK735HH2TJOSELLZLRNTQM5MCBANCNFSM4I5Q5TWA> .

[jpkrohling]

Would it be sufficient to suppress the UI from displaying it, or are you looking to avoid even adding this tag to the span being reported?

[jpkrohling]

By the way, I'm quite sure this is added in the backend, so, it shouldn't be costing any network activity.

[pavolloffay]

It is added in Jaeger collector https://github.com/pavolloffay/jaeger/blob/343fcc6ddd3bdb94dec864bddc2ff8794d6666a8/cmd/collector/app/span_processor.go#L160.

If there is no valid use case to hide it or remove it we will probably close this ticket. Other Jaeger components can rely on this tag while doing another processing. It was added as #1490.

[smanolloff]

I agree with @zheyiyi -- having this appear among other (user-defined) tags is actually undesirable. Internal tags have no place in the UI, unless specifically enabled for debugging purposes.

[yurishkuro]

We can either have configuration for the UI to hide some tags, or have an option in the collector to not add these tags if people don't want them.

[smanolloff]

Hiding tags in the UI is fine by me (eg. with regex).

[apm-opentt]

The internal.span.format ="jaeger" tag actually helps me in debugging. Our Jaeger collector receives Jaeger spans and Zipkin spans. With the internal.span.format I can see at a glance in Jaeger UI whether the span came from Jaeger or Zipkin. It is very useful. Please keep it.

[yurishkuro]

@apm-opentt same here, that's why we added it.

[pavolloffay]

Note that this tag is not being added in Jager OTEL components. It's only added in collector's processors which are not being used in OTEL.

I find the tag useful to understand the instrumentation layer. Perhaps we could add this to OTEL spec and then use OTEL attribute processor to remove the label https://github.com/open-telemetry/opentelemetry-collector/tree/master/processor#attributes. However, the processor does not work on resource/process objects. Perhaps we could extend it to support this feature.

[ndrwrbgs]

I'd like to be able to configure the visibility of the tag in the UI. While it's useful for me, like previous commenters on this thread, as the tracing implementor, I think it's distracting from the content for my consumers (developer peers).

[cptkng23]

Is there any update on how to remove this tag. Be it UI or collector?

[kgunnerud]

Would be nice if it could be configured for example by using the --query.ui-config file. For us, it would be nice to hide a few selected tags that as of now give us little to no benefits

[yurishkuro]

--query.ui-config is one option but it means the data would still be returned to the UI and just not displayed. Another alternative is a cli flag to the query service to suppress returning certain tags in the JSON response (may be easier to implement).

[pmuls99]

--query.ui-config is one option but it means the data would still be returned to the UI and just not displayed. Another alternative is a cli flag to the query service to suppress returning certain tags in the JSON response (may be easier to implement).

This way of implementing it feels right! As the problem is still prominent, can I go ahead with the implementation @yurishkuro.

[yurishkuro]

@pmuls99 my preference is to use UI config to filter out some tags from being displayed.

[yurishkuro]

Closing since nobody feels strongly enough to provide a fix and this won't be present in jaeger-v2 anyway