Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kerberos authentication for KDCs like Active Directory that do not support FAST negotiation #2744

Closed
kaz-zahed opened this issue Jan 27, 2021 · 3 comments
Closed

Kerberos authentication for KDCs like Active Directory that do not support FAST negotiation #2744

kaz-zahed opened this issue Jan 27, 2021 · 3 comments
Labels
enhancement good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement

Comments

@kaz-zahed
Copy link

Requirement - what kind of business use case are you trying to solve?

Kerberos authentication for KDCs like Active Directory that do not support FAST negotiation.

Problem - what in Jaeger blocks you from solving the requirement?

Jaeger does not expose the configuration property that allows disabling FAST negotiation for Kerberos authentication.

Proposal - what do you suggest to solve the problem or improve the existing situation?

Shopify/sarama Kafka library exposed this configuration property with release v1.27.0 with this pull request. Jaeger's Kafka Kerberos authentication configuration can be updated to allow configuring this property.

Any open questions to address
@yurishkuro yurishkuro added enhancement help wanted Features that maintainers are willing to accept but do not have cycles to implement good first issue Good for beginners and removed needs-triage labels Jan 27, 2021
@kaz-zahed kaz-zahed mentioned this issue Jan 27, 2021
Closed
@pmuls99
Copy link
Contributor

pmuls99 commented Jun 7, 2023

Hey @kaz-zahed, @yurishkuro seems like the PR raised for this issue is closed. Could I take this up and raise a PR?

@yurishkuro
Copy link
Member

Feel free to try

@pmuls99 pmuls99 mentioned this issue Jun 9, 2023
Merged
@pmuls99
Copy link
Contributor

pmuls99 commented Jun 9, 2023

Hey @yurishkuro , I just raised a PR (#4520)addressing the issue. Could you please take a look and give me pointers on improvement!

yurishkuro added a commit that referenced this issue Jun 11, 2023
@pmuls99 @severussnape321 @yurishkuro
Add *.kerberos.disable-fast-negotiation option to Kafka consumer (#4520)
71290f4 
## Which problem is this PR solving?
- Solves #2744 

## Short description of the changes
- Added a variable in KerberosConfig struct and configured it 
- Added flags and the configuration for the same

---------

Signed-off-by: bugslayer-332 <ayashwanth9503@gmail.com>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Co-authored-by: bugslayer-332 <ayashwanth9503@gmail.com>
Co-authored-by: Yuri Shkuro <github@ysh.us>
kjschnei001 pushed a commit to kjschnei001/jaeger that referenced this issue Jun 29, 2023
@pmuls99 @severussnape321
@yurishkuro @kjschnei001
Add *.kerberos.disable-fast-negotiation option to Kafka consumer (jae…
fee3166 
…gertracing#4520)

## Which problem is this PR solving?
- Solves jaegertracing#2744

## Short description of the changes
- Added a variable in KerberosConfig struct and configured it
- Added flags and the configuration for the same

---------

Signed-off-by: bugslayer-332 <ayashwanth9503@gmail.com>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Co-authored-by: bugslayer-332 <ayashwanth9503@gmail.com>
Co-authored-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: KevinSchneider <kevin.schneider@target.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yurishkuro @kaz-zahed @pmuls99