Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration property that allows disabling FAST negotiation for… #2745

Closed
wants to merge 1 commit into from
Closed

Add configuration property that allows disabling FAST negotiation for… #2745

wants to merge 1 commit into from

Conversation

kaz-zahed
Copy link

… Kerberos authentication

Signed-off-by: Kaz Zahed kaz.zahed@att.com

Which problem is this PR solving?

Short description of the changes

  • Upgrade Shopify/sarama Kafka library to v1.27.2
  • Add configuration property that allows disabling FAST negotiation for Kerberos authentication

… Kerberos authentication

Signed-off-by: Kaz Zahed <kaz.zahed@att.com>
@kaz-zahed kaz-zahed requested a review from a team as a code owner January 27, 2021 19:56
@kaz-zahed kaz-zahed requested a review from joe-elliott January 27, 2021 19:56
@codecov
Copy link

codecov bot commented Jan 27, 2021

Codecov Report

Merging #2745 (a96cba3) into master (2ff0a3d) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2745      +/-   ##
==========================================
- Coverage   95.83%   95.82%   -0.02%     
==========================================
  Files         217      217              
  Lines        9656     9656              
==========================================
- Hits         9254     9253       -1     
- Misses        331      332       +1     
  Partials       71       71              
Impacted Files Coverage Δ
cmd/query/app/static_handler.go 94.35% <0.00%> (-0.81%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ff0a3d...a96cba3. Read the comment docs.

suffixKerberosPassword = ".password"
suffixKerberosConfig = ".config-file"
suffixKerberosKeyTab = ".keytab-file"
suffixKerberosDisablePAFXFAST = ".disable-pa-fx-fast"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the description you refer to this as "FAST negotiation". Is it important to have "pa-fx"? If so, it would be better to spell them out in the flag description too.

@yurishkuro
Copy link
Member

I restarted CIT Kafka job. If it fails again it might be due to this change.

@yurishkuro
Copy link
Member

Kafka integration test failed again

@jpkrohling
Copy link
Contributor

@kaz-zahed could you please double-check the Kafka failure?

@Ahmedzehad
Copy link

go.mod
go.sum

@jpkrohling
Copy link
Contributor

What's the current status of this PR?

@stale
Copy link

stale bot commented Apr 16, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. You may re-open it if you need more time.

@stale stale bot added the stale The issue/PR has become stale and may be auto-closed label Apr 16, 2022
@stale
Copy link

stale bot commented Apr 30, 2022

This pull request has been automatically closed due to inactivity. You may re-open it if you need more time. We really appreciate your contribution and we are sorry that this has not been completed.

@stale stale bot closed this Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale The issue/PR has become stale and may be auto-closed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants