Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose otel configured thrift http port #3986

Merged
merged 2 commits into from
Oct 20, 2022
Merged

Expose otel configured thrift http port #3986

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c811a31
Expose otel configured thrift http port
albertteoh Oct 19, 2022
c372522
Merge branch 'main' into expose-traces-http-port
albertteoh Oct 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docker-compose/monitor/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ services:
volumes:
- "./otel-collector-config.yml:/etc/otelcol/otel-collector-config.yml"
command: --config /etc/otelcol/otel-collector-config.yml
ports:
- "14278:14278"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Should there be that many ports exposed from all-in-one? It seems in this setup all collection should go through OTEL collector.
  2. May be useful to explain this in the readme.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback @yurishkuro, good points. I'll address them in a follow-up PR.

depends_on:
- jaeger
microsim:
Expand Down