Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release]: 1.0.1 Service Release #762

Closed
25 tasks done
KyleAure opened this issue Jun 7, 2024 · 14 comments · Fixed by jakartaee/specifications#775
Closed
25 tasks done

[Release]: 1.0.1 Service Release #762

KyleAure opened this issue Jun 7, 2024 · 14 comments · Fixed by jakartaee/specifications#775
Assignees
@KyleAure
Labels
release Issue that proposes a new release

Comments

@KyleAure
Copy link
Contributor

KyleAure commented Jun 7, 2024 •
edited
Loading

Proposal

During the release review process some issues were brought up that will require us to do an immediate service release.

Outstanding work

Check List

Prepare

Stage release

Verify and modify

  • Ask for feedback from the community to verify the staged artifact has all the expected changes.
  • If anything needs to be added before publishing do that now and repeat the Stage Release section

Publish release

Follow up
@KyleAure KyleAure added the release Issue that proposes a new release label Jun 7, 2024
@KyleAure KyleAure self-assigned this Jun 7, 2024
@KyleAure
Copy link
Contributor Author

1.0.1 is staged

Verification Data

file sha256
data-tck-1.0.1.zip 9f3c74d4ebe3116501520a19851214eb87d1e671056829e95696cf1e263a187a

This was referenced Jun 10, 2024
Merged
Closed
@KyleAure
Copy link
Contributor Author

KyleAure commented Jul 3, 2024

1.0.1 is re-staged

Verification Data

file sha256
data-tck-1.0.1.zip 20d3e77db8a6335472fb153b370c5ea7ab876e727b858472153b8bf274a2b6dc

FYI @otaviojava

@KyleAure
Copy link
Contributor Author

KyleAure commented Sep 19, 2024 •
edited
Loading

1.0.1 is re-staged

Verification Data

file sha256
data-tck-1.0.1.zip 92babb604b4e346f8d19929979c1d6aaf013fdf990b5e97bdd95502ad7db5b4c

FYI @otaviojava @njr-11 @gavinking
I will test the new staged TCK against Open Liberty ✅ -- Passing locally
Let me know if you are satisfied with this service release and I can work on getting it published/promoted.

KyleAure added a commit to KyleAure/open-liberty that referenced this issue Sep 19, 2024
@KyleAure
Run with staged TCK jakartaee/data#762
558ff8d
@KyleAure
Copy link
Contributor Author

@otaviojava - Just following up. Have you been able to run with this new staged version? If everything is good on your side let me know and I can publish 1.0.1.

@otaviojava
Copy link
Contributor

@otaviojava - Just following up. Have you been able to run with this new staged version? If everything is good on your side let me know and I can publish 1.0.1.

Please, let me test it today; I will bring an update tomorrow morning.

@otaviojava
Copy link
Contributor

@keilw

While the 1.0.1-SNAPSHOT is working.

[INFO] Tests run: 73, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.456 s - in org.eclipse.jnosql.tck.MyEntityTests
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 74, Failures: 0, Errors: 0, Skipped: 0
[INFO]

The version 1.0.1 is not, could you check if it is missing some code?

[ERROR]   MyEntityTests>EntityTests.testUpdateQueryWithoutWhereClause:2115 » UnsupportedOperation The return type must be Void when the query is not a SELECT operation, due to the nature of DELETE and UPDATE operations. The query: DELETE FROM Box
[INFO] 
[ERROR] Tests run: 74, Failures: 5, Errors: 9, Skipped: 0

@KyleAure
Copy link
Contributor Author

KyleAure commented Sep 24, 2024 •
edited
Loading

@otaviojava how are you pulling the 1.0.1 TCK?
https://jakarta.oss.sonatype.org/content/repositories/staging/ -> 1.0.1 was uploaded Jul 03
https://jakarta.oss.sonatype.org/content/repositories/jakartadata-1027/ -> 1.0.1 was uploaded Sep 19

I think there may have been an issue with our Jenkins build. I looked back at the output and see:

-[ Drop old staging repository deployments ]------------------------------------
Sep 19, 2024 3:26:48 PM com.sun.jersey.api.client.ClientResponse getEntity
SEVERE: A message body reader for Java class com.sonatype.nexus.staging.api.dto.StagingRuleFailuresDTO, and Java type class com.sonatype.nexus.staging.api.dto.StagingRuleFailuresDTO, and MIME media type text/html was not found
Sep 19, 2024 3:26:48 PM com.sun.jersey.api.client.ClientResponse getEntity

I think the previous version was never deleted. I'll look into it

@otaviojava
Copy link
Contributor

@otaviojava how are you pulling the 1.0.1 TCK? https://jakarta.oss.sonatype.org/content/repositories/staging/ -> 1.0.1 was uploaded Jul 03 https://jakarta.oss.sonatype.org/content/repositories/jakartadata-1027/ -> 1.0.1 was uploaded Sep 19

I think there may have been an issue with our Jenkins build. I looked back at the output and see:

-[ Drop old staging repository deployments ]------------------------------------
Sep 19, 2024 3:26:48 PM com.sun.jersey.api.client.ClientResponse getEntity
SEVERE: A message body reader for Java class com.sonatype.nexus.staging.api.dto.StagingRuleFailuresDTO, and Java type class com.sonatype.nexus.staging.api.dto.StagingRuleFailuresDTO, and MIME media type text/html was not found
Sep 19, 2024 3:26:48 PM com.sun.jersey.api.client.ClientResponse getEntity

I think the previous version was never deleted. I'll look into it

I downloaded it from Maven.

@KyleAure
Copy link
Contributor Author

Can you try using the version uploaded to jakarta.oss.sonatype.org/content/repositories/jakartadata-1027

@KyleAure
Copy link
Contributor Author

I think the issue was likely on the sonatype server side. I just did a dry-run of the jenkins build and it was able to get a list of old repositories to drop:

-[ Drop old staging repository deployments ]------------------------------------
Repository ID: jakartadata-1026
Repository ID: jakartadata-1027

I could re-stage this again, or just continue forward with using jakarta.oss.sonatype.org/content/repositories/jakartadata-1027 which is what all our build automation is based on.

@otaviojava
Copy link
Contributor

otaviojava commented Sep 30, 2024 •
edited
Loading

Hey @KyleAure, how can I do this?

I am manually removing the version in the .m2 folder, but it is still with the version of July.

Screenshot 2024-09-30 at 08 34 24

@KyleAure
Copy link
Contributor Author

@otaviojava Update your pom.xml to use

<repositories>
  <repository>
    <id>sonatype-nexus-staging</id>
    <name>Sonatype Nexus Staging</name>
    <url>https://jakarta.oss.sonatype.org/content/repositories/jakartadata-1027/</url>
    <releases>
      <enabled>true</enabled>
    </releases>
    <snapshots>
      <enabled>true</enabled>
    </snapshots>
</repositories>

@otaviojava
Copy link
Contributor

It is working now, thanks @KyleAure

@KyleAure
Copy link
Contributor Author

1.0.1 Service Release is published

Verification Data

file sha256
data-tck-1.0.1.zip 92babb604b4e346f8d19929979c1d6aaf013fdf990b5e97bdd95502ad7db5b4c

@KyleAure KyleAure mentioned this issue Sep 30, 2024
Merged
1 task
KyleAure added a commit to KyleAure/open-liberty that referenced this issue Oct 1, 2024
@KyleAure
Run with staged TCK jakartaee/data#762
c4a664f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KyleAure KyleAure

Labels
release Issue that proposes a new release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Jakarta Data 1.0.1 KyleAure/specifications
2 participants
@otaviojava @KyleAure