-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix concerns with tck-dist #738
Merged
KyleAure
merged 8 commits into
jakartaee:main
from
KyleAure:737-updates-to-jakarta-data-tck
Jun 7, 2024
Merged
Fix concerns with tck-dist #738
KyleAure
merged 8 commits into
jakartaee:main
from
KyleAure:737-updates-to-jakarta-data-tck
Jun 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e7969fd
to
27de88f
Compare
njr-11
approved these changes
May 15, 2024
Wait to merge until we know if this needs to be included in 1.0.0 or if it can wait for 1.0.1 |
lukasj
reviewed
May 16, 2024
lukasj
reviewed
May 16, 2024
lukasj
reviewed
May 16, 2024
lukasj
reviewed
May 16, 2024
lukasj
reviewed
May 16, 2024
94f6a52
to
5d02dfa
Compare
5d02dfa
to
0b91682
Compare
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #737
FYI @edburns @lukasj
Tested dependabot in my fork and it worked:
![Screenshot 2024-05-15 at 13 23 07](https://private-user-images.githubusercontent.com/33664635/330919252-b37aa975-48e3-443b-88d2-62e32fb91857.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzNzM4NjQsIm5iZiI6MTczOTM3MzU2NCwicGF0aCI6Ii8zMzY2NDYzNS8zMzA5MTkyNTItYjM3YWE5NzUtNDhlMy00NDNiLTg4ZDItNjJlMzJmYjkxODU3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDE1MTkyNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTliNTIyZGQ1Zjc1MmZjOWQwODNhYzU1MTQyOTQzNzZhY2YwMmExNDZmZmI1Y2QwY2QxZGE1OWM2NDJkMTg4MGImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.lpLKFnGyRxI7r1rSCuZMbwjBxC8EUVw2ZQAB4-Z1g4g)