simplify testing registration of AddressRepository, DirectoryRepository #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests are supposed to be validating that the JD implementation is ignoring the Directory and AddressBook repository interfaces. It does not need to be testing stuff related to handling of CDI extensions running on Arquillian/Shrinkwrap, and so none of this complexity is necessary. see jakartaee#709
KyleAure
approved these changes
Apr 18, 2024
|
Excellent, thanks @KyleAure |
njr-11
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests are supposed to be validating that the Jakarta Data implementation is ignoring the
DirectoryandAddressBookrepository interfaces. It does not need to be testing stuff related to handling of CDI portable extensions running on Arquillian/Shrinkwrap, and so none of this complexity is necessary.fixes #709