Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify testing registration of AddressRepository, DirectoryRepository #710

Merged
merged 1 commit into from
Apr 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
*/
package ee.jakarta.tck.data.common.cdi;

import jakarta.enterprise.context.Dependent;

import java.util.HashMap;
import java.util.List;
import java.util.Map;
Expand All @@ -25,6 +27,7 @@
* An implementation of the AddressBook repository interface.
* Implementation is backed by an in-memory HashMap.
*/
@Dependent
public class AddressRepository implements AddressBook {

private Map<UUID, AddressRecord> data = new HashMap<UUID, AddressRecord>();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
*/
package ee.jakarta.tck.data.common.cdi;

import jakarta.enterprise.context.Dependent;

import java.util.Comparator;
import java.util.HashMap;
import java.util.List;
Expand All @@ -25,6 +27,7 @@
* An implementation of the Directory repository interface.
* Implementation is backed by an in-memory HashMap and has one function.
*/
@Dependent
public class DirectoryRepository implements Directory {

private Map<Long, Person> data = new HashMap<Long, Person>();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,19 +23,16 @@

import org.jboss.arquillian.container.test.api.Deployment;
import org.jboss.shrinkwrap.api.ShrinkWrap;
import org.jboss.shrinkwrap.api.spec.JavaArchive;
import org.jboss.shrinkwrap.api.spec.WebArchive;

import ee.jakarta.tck.data.common.cdi.AddressBook;
import ee.jakarta.tck.data.common.cdi.AddressRecord;
import ee.jakarta.tck.data.common.cdi.Directory;
import ee.jakarta.tck.data.common.cdi.Person;
import ee.jakarta.tck.data.core.cdi.provider.BuildCompatibleExtensionImpl;
import ee.jakarta.tck.data.framework.junit.anno.AnyEntity;
import ee.jakarta.tck.data.framework.junit.anno.Assertion;
import ee.jakarta.tck.data.framework.junit.anno.CDI;
import ee.jakarta.tck.data.framework.junit.anno.Core;
import jakarta.enterprise.inject.build.compatible.spi.BuildCompatibleExtension;
import jakarta.inject.Inject;

@Core
Expand All @@ -44,16 +41,9 @@
public class ExtensionTests {
@Deployment
public static WebArchive createDeployment() {
JavaArchive provider = ShrinkWrap.create(JavaArchive.class)
.addPackage(BuildCompatibleExtensionImpl.class.getPackage())
.addAsServiceProvider(BuildCompatibleExtension.class, BuildCompatibleExtensionImpl.class);


return ShrinkWrap.create(WebArchive.class)
.addPackage(ExtensionTests.class.getPackage())
.addPackage(Person.class.getPackage())
.addAsLibraries(provider);

.addPackage(Person.class.getPackage());
}

@Inject
Expand Down

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@

import org.jboss.arquillian.container.test.api.Deployment;
import org.jboss.shrinkwrap.api.ShrinkWrap;
import org.jboss.shrinkwrap.api.spec.JavaArchive;
import org.jboss.shrinkwrap.api.spec.WebArchive;

import ee.jakarta.tck.data.common.cdi.AddressBook;
Expand All @@ -34,8 +33,6 @@
import ee.jakarta.tck.data.framework.junit.anno.Assertion;
import ee.jakarta.tck.data.framework.junit.anno.CDI;
import ee.jakarta.tck.data.framework.junit.anno.Web;
import ee.jakarta.tck.data.web.cdi.provider.ExtensionImpl;
import jakarta.enterprise.inject.spi.Extension;
import jakarta.inject.Inject;

@Web
Expand All @@ -44,15 +41,9 @@
public class ExtensionTests {
@Deployment
public static WebArchive createDeployment() {
JavaArchive provider = ShrinkWrap.create(JavaArchive.class)
.addPackage(ExtensionImpl.class.getPackage())
.addAsServiceProvider(Extension.class, ExtensionImpl.class);


return ShrinkWrap.create(WebArchive.class)
.addPackage(ExtensionTests.class.getPackage())
.addPackage(Person.class.getPackage())
.addAsLibraries(provider);
.addPackage(Person.class.getPackage());

}

Expand Down

This file was deleted.

Loading