Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving failing TCK #235

Merged
merged 3 commits into from
Sep 26, 2022
Merged

Resolving failing TCK #235

merged 3 commits into from
Sep 26, 2022

Commits on Sep 26, 2022

  1. The xml-apis are not required on classpath

    Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
    dmatej committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    e1de679 View commit details
    Browse the repository at this point in the history
  2. Partial cleanup in xml package

    - Maybe (!!!) fixes race condition in GlassFish. Since this change the TCK
      jstl/spec/xml/xmlcore/types passed several times without failing.
      However, I am still not convinced, because the failure wasn't well
      reproducible and also the cause wasn't clearly visible.
    - XPathUtil doesn't set system properties any more (see XPathUtil).
    - DocumentBuilderFactory should not be used as a constant,
      it is not thread-safe. Despite in this case I doubt it could cause issue,
      I cannot be sure.
    - Deleted unused methods
    - JSTLNodeList moved to own file
    - Deleted copy pasted javadocs from old versions
    - More should be done, but let's start with this.
    
    
    Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
    dmatej committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    8cf656a View commit details
    Browse the repository at this point in the history
  3. DocumentBuilderFactory is safe to be a constant if we don't change it.

    Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
    dmatej committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    2ccb17a View commit details
    Browse the repository at this point in the history