RuboCop Stage I: Update and improve production gem #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tagliala
force-pushed
the
chore/modernize-rubocop
branch
4 times, most recently
from
a6d74d6
to
8ab7fd4
Compare
tagliala
changed the title
tagliala
force-pushed
the
chore/modernize-rubocop
branch
from
8ab7fd4
to
311d412
Compare
This was referenced Sep 16, 2024
tagliala
force-pushed
the
chore/modernize-rubocop
branch
from
311d412
to
0fd8420
Compare
tagliala
changed the title
tagliala
force-pushed
the
chore/modernize-rubocop
branch
from
0fd8420
to
20ad7f4
Compare
|
@jamesmartin rebased and ready for review |
Pinning to an exact version will prevent breaking the CI with new offenses
- Gemspec/DeprecatedAttributeAssignment - Packaging/GemspecGit - Style/Encoding - Style/ExpandPathArguments - Style/PercentLiteralDelimiters - Style/RedundantPercentQ - Style/SpecialGlobalVars Also: - Add frozen string literal magic comment - Exclude spec files from production gem (size from 31K to 18K)
tagliala
force-pushed
the
chore/modernize-rubocop
branch
from
20ad7f4
to
641a1d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #168