Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editing_style: :delete is broken starting with v2.3.1 #690

Closed
wallclimber21 opened this issue May 14, 2015 · 2 comments · Fixed by #694
Closed

editing_style: :delete is broken starting with v2.3.1 #690

wallclimber21 opened this issue May 14, 2015 · 2 comments · Fixed by #694
Assignees

Comments

@wallclimber21
Copy link

Hello Promotion crew,

It looks like the editing_style: :delete option is broken in the current Promotion release (v2.3.1).

I'm simply testing it by changing the app_delegate in the main repo to use TestTableScreen instead of BasicScreen, and deletable rows just don't react at all when you swipe left.

v2.3.0 works fine when left sliding the 'Just another deletable blank work'.
v2.3.1 doesn't do anything at all.

I've isolated the issue to commit f88864f.

It looks like the self.extend either doesn't work when running as a real app, yet the spec test seems to be fine. Weird.

Tom

@wallclimber21 wallclimber21 changed the title editing_style: :delete is broken editing_style: :delete is broken starting with v2.3.1 May 14, 2015
@markrickert
Copy link
Contributor

markrickert commented May 14, 2015 via email

@markrickert
Copy link
Contributor

Discussion is going on on #653

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants