Bug/690 edit table #694
Merged
Bug/690 edit table #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: Fixed brittle web request specs (cc @markrickert) Forgot this one cell_at index_path. New cell_at method for a absracted way to get the cell data. Remove development dependency for motion_print Development and runtime for MP Add will_display_cell documentation Implemented will_display_cell Remove v number on rake Removes internal usage and documentation of Logger Adds deprecation warning for PM.logger Adds motion_print dependency # Conflicts: # spec/unit/tables/table_screen_spec.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #690
Reference: #653
@austinseraphin has confirmed that this fixes the issue while maintaining proper accessibility voiceover on non-deletable cells.
We should probably merge this and release a bugfix version.
Note the other issue he posted in #653 about
:insertmode: #653 (comment) Possibly related, but waiting on a proper bug report/issue from Austin with more details.