Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github: windows-latest build env will switch to windows-2022 soon and will break CodeQL #2259

Closed
2 tasks done
hoffie opened this issue Jan 21, 2022 · 4 comments · Fixed by #2649
Closed
2 tasks done

Github: windows-latest build env will switch to windows-2022 soon and will break CodeQL #2259

hoffie opened this issue Jan 21, 2022 · 4 comments · Fixed by #2649
Labels
bug Something isn't working
Milestone
Release 3.9.0

Comments

@hoffie
Copy link
Member

hoffie commented Jan 21, 2022 •
edited by ann0see
Loading

Describe the bug

Windows builds currently show this annotation on the Actions tab:

windows-latest workflows will use windows-2022 soon. For more details, see actions/runner-images#4856

Also see github/codeql-action#850
@ann0see tried building with windows-2022 explicitly and it failed in CodeQL:
https://github.com/ann0see/jamulus/runs/4858827768?check_suite_focus=true

Error: Tracing builds with CodeQL is currently not supported on Windows 11 and Windows Server 2022. Please modify your Actions workflow to use an earlier version of Windows for this job, for example by setting runs-on: windows-2019.

We should therefore pin to windows-2019 for now.

  • Pin to windows-2019
  • Leave this ticket open as a reminder to switch to windows-2022 once CodeQL is fixed and no other stuff breaks (or find another way to remind us)
@hoffie hoffie added the bug Something isn't working label Jan 21, 2022
@softins
Copy link
Member

softins commented Jan 21, 2022

Pinned to 2019 in 5a181d1

@hoffie hoffie added this to the Release 3.9.0 milestone Jan 21, 2022
@hoffie
Copy link
Member Author

hoffie commented Jan 21, 2022

Tagging for 3.9.0 in order to be reminded to re-check then. If CodeQL doesn't have support for it by then, we'll just move the issue to the next bigger milestone.

@Kay-kay2019

This comment was marked as off-topic.

Sign in to view
@Kay-kay2019

This comment was marked as off-topic.

Sign in to view
ann0see added a commit to ann0see/jamulus that referenced this issue Jun 15, 2022
@ann0see
Autobuild: Upgrade Windows build environment
2e647ae 
Fixes: jamulussoftware#2259
Visual Studio and CodeQl now work on windows-2022 according to github/codeql-action#850
@ann0see ann0see mentioned this issue Jun 15, 2022
Merged
5 tasks
ann0see added a commit to ann0see/jamulus that referenced this issue Jun 18, 2022
@ann0see
Autobuild: Upgrade Windows build environment to 2022
23a4132 
Fixes: jamulussoftware#2259
Visual Studio and CodeQl now work on windows-2022 according to 
github/codeql-action#850
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Release 3.9.0
Development

Successfully merging a pull request may close this issue.

Autobuild: Upgrade Windows build environment ann0see/jamulus
3 participants
@hoffie @softins @Kay-kay2019