Autobuild: Upgrade Windows build environment #2649
Conversation
.github/workflows/autobuild.yml
Outdated
| @@ -159,13 +159,13 @@ jobs: | |||
|
|
|||
| - config_name: Windows (artifact+codeQL) | |||
| target_os: windows | |||
| building_on_os: windows-2019 | |||
| building_on_os: windows-latest | |||
There was a problem hiding this comment.
Is there a pinnable version?
There was a problem hiding this comment.
Yes. windows-2022 probably
There was a problem hiding this comment.
I'd prefer that rather than something that could change.
|
Have you run the auto-build on this branch on Github? Are the artifacts available? |
|
Yes. You can test the artifices. According to the log they‘ve been built on the latest windows version with VS 22 |
|
Well the ASIO(tm) build lets me listen okay. I've not had a chance to test anything more than that but I can't think it would have a problem if it works that far. I can't test JACK (it still crashes for me - JACK, not Jamulus). |
|
@henkdegroot can test JACK on Windows, I suppose. But I doubt there's anything wrong with it |
There was a problem hiding this comment.
Great, thanks!
As @pljones mentioned, please try the pinned OS version. Besides that, approving (I can't test on Windows, but I guess it's fine if @pljones and @henkdegroot do).
|
@ann0see / @hoffie, annoying fact (again) I can't download the artifact. After the download completes, Microsoft detects a trojan in the jack exe. Can you try to download and see if you get the same result? FYI, I suspect it is a falls positive and have submitted the zip file to microsoft (just in case that helps). |
|
@henkdegroot the Windows JACK build opens fine for me -- you mean the installer, I take it? Or do you mean after install? |
|
@pljones I mean that when I download the jack zip file from the autobuild, Windows detects a threat and blocks the download after it completed. |
|
I don't get that at all - but then, I've optimised my PC for real-time audio heavily by turning off background stuff I don't want. All that message usually means is you've got checking enabled and Microsoft hasn't had the content of the file confirmed as safe. As it's a "one off" payload, it's never going to get that. So you'll need to override it's "wisdom". |
Fixes: jamulussoftware#2259 Visual Studio and CodeQl now work on windows-2022 according to github/codeql-action#850
Is that more prevalent after this PR? I think it is expected that non-famous Jamulus builds cause warnings. However, specific detections sound like something to investigate. Interestingly, on Virustotal the files are not flagged by Microsoft (but by 1-2 other scanners in rather generic ways). Jack and ASIO seem similar though:
|
There was a problem hiding this comment.
I don't see a VirusTotal regression when comparing the artifacts from here with one of the latest master builds:
https://www.virustotal.com/gui/file-analysis/MmQ1YjQ4N2RlMjRkODY3YjZlOGU2ZTc2OTkyZGMzYjM6MTY1NTU4NDkyMQ==
Therefore, approving.
|
@hoffie, no problems with warnings. I did not have any problem downloading the ASIO version, only the windows jack version. Interesting to see why Microsoft Defender is triggering this high security and blocks the file. When I unblock the zip file and try to extract it I get more (other) trojan warnings being detected. Just annoying.... |
|
FWIW, I actually got feedback from Microsoft about the file being false positive and they have updated their signatures....will see if these submissions can really help for future cases as well. |
Visual Studio and CodeQl now work on windows-2022 according to github/codeql-action#850
Short description of changes
CHANGELOG: Autobuild: Build Windows version on latest build environment. This upgrades the Windows build process
Context: Fixes an issue?
Fixes: #2259
Does this change need documentation? What needs to be documented and how?
No.
Status of this Pull Request
Needs testing on Windows. Hopefully the upgrade has only positive side-effects.
What is missing until this pull request can be merged?
Checklist