Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration and deprecation of -m option in favor of JSON RPC #3362

Open
ann0see opened this issue Aug 30, 2024 · 3 comments
Open

Integration and deprecation of -m option in favor of JSON RPC #3362

ann0see opened this issue Aug 30, 2024 · 3 comments
Labels
refactoring Non-behavioural changes, Code cleanup
Milestone
Release 3.12.0

Comments

@ann0see
Copy link
Member

ann0see commented Aug 30, 2024 •
edited
Loading

It is worth discussing deprecating the -m option and/or integrating missing features it into JSON RPC. It's not a core feature of Jamulus.

I think we had this discussion a while ago. Cc: @pljones

jamulussoftware/jamuluswebsite#1019 (comment)
@ann0see ann0see changed the title Integration and deprecation of -m option in favor of JSON RPV Integration and deprecation of -m option in favor of JSON RPC Aug 30, 2024
@pljones
Copy link
Collaborator

pljones commented Aug 30, 2024

Yep, --htmlstatus should probably be marked deprecated in 3.12.0. The client list is available from the server either over UDP (acting as a client, the way @softins's PHP does it) or using the JSON-RPC calls.

@pljones pljones added this to Tracking Aug 30, 2024
@pljones pljones added this to the Release 3.12.0 milestone Aug 30, 2024
@github-project-automation github-project-automation bot moved this to Triage in Tracking Aug 30, 2024
@pljones pljones moved this from Triage to Backlog in Tracking Aug 30, 2024
@ann0see
Copy link
Member Author

ann0see commented Aug 30, 2024 •
edited
Loading

The website already calls it deprecated today: https://jamulus.io/wiki/Running-a-Server#-m-or---htmlstatus

I think we should

@ann0see
Copy link
Member Author

ann0see commented Aug 30, 2024

Ok. After checking the output it's really just the connected clients' names.

@ann0see ann0see added the refactoring Non-behavioural changes, Code cleanup label Sep 6, 2024
ann0see added a commit to ann0see/jamulus that referenced this issue Oct 4, 2024
@ann0see
Add depcrecation warning for -m option
fb322a0 
To get a client list, JSON RPC should be used instead of `--htmlstatus`/`-m`.
Check out https://github.com/jamulussoftware/jamulus/blob/main/docs/JSON-RPC.md for more information on JSON RPC.

Related to: jamulussoftware#3362
ann0see added a commit to ann0see/jamulus that referenced this issue Oct 4, 2024
@ann0see
Add depcrecation warning for -m option
e597230 
To get a client list, JSON RPC should be used instead of `--htmlstatus`/`-m`.
Check out https://github.com/jamulussoftware/jamulus/blob/main/docs/JSON-RPC.md for more information on JSON RPC.

Related to: jamulussoftware#3362
@ann0see ann0see mentioned this issue Oct 4, 2024
Open
5 tasks
ann0see added a commit to ann0see/jamulus that referenced this issue Oct 8, 2024
@ann0see
Add depcrecation warning for -m option
20684eb 
To get a client list, JSON RPC should be used instead of `--htmlstatus`/`-m`.
Check out https://github.com/jamulussoftware/jamulus/blob/main/docs/JSON-RPC.md for more information on JSON RPC.

Related to: jamulussoftware#3362

Rephrase deprecation text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring Non-behavioural changes, Code cleanup
Projects
Tracking
Status: Backlog
Milestone
Release 3.12.0
Development

No branches or pull requests
2 participants
@pljones @ann0see