Add deprecation warning for -m option
#3398
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pljones
reviewed
Oct 5, 2024
To get a client list, JSON RPC should be used instead of `--htmlstatus`/`-m`. Check out https://github.com/jamulussoftware/jamulus/blob/main/docs/JSON-RPC.md for more information on JSON RPC. Related to: jamulussoftware#3362 Rephrase deprecation text
ann0see
force-pushed
the
refactoring/deprecateCLIM
branch
from
99a0601
to
20684eb
Compare
pljones
added
needs documentation
pljones
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a deprecation warning if the server is started with
-m.Short description of changes
CHANGELOG: The
-m/--htmlstatusoption is considered deprecated and has been replaced by JSON RPC'sjamulusserver/getClientsmethod. The-moption will be removed in future.Context: Fixes an issue?
Related to: #3362
Does this change need documentation? What needs to be documented and how?
Yes. Part of #3362
Status of this Pull Request
What is missing until this pull request can be merged?
Approval.
Checklist