Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RYG indicator lights need colour-blind compensation #57

Closed
gilgongo opened this issue Apr 11, 2020 · 24 comments
Closed

RYG indicator lights need colour-blind compensation #57

gilgongo opened this issue Apr 11, 2020 · 24 comments
Labels
feature request Feature request

Comments

@gilgongo
Copy link
Member

gilgongo commented Apr 11, 2020

Red–green colour blindness affects up to 8% of males and 0.5% of females of Northern European descent. Colours of traffic lights are confusing to these people as there is insufficient apparent difference between them.

To avoid discriminating against red-green colour blind people, suggest adding textual status to avoid confusion:

image

Another approach

Maybe use blink rates? Not as clear - the user has to know what the blink rates mean - but once they know they can remember forever. Might also help those without colour blindness too.

  • No blinking (steady) on Green
  • Slow blinking on Yellow
  • Fast blinking on Red
@pljones
Copy link
Collaborator

pljones commented Apr 11, 2020

:) Maybe "Poor"...

@corrados corrados added the feature request Feature request label Apr 12, 2020
@trebmuh
Copy link
Member

trebmuh commented Apr 12, 2020

I agree. I'm color blind and those color are hard to see for me.

@FabriceReynolds
Copy link

I also agree as I'm colour blind too and the green and yellow almost look the same to me

@corrados
Copy link
Contributor

This is related to that: #71. I''ll try to fix both.

@Skeezixes
Copy link

I am not discouraging anyone from adding explanatory text, but in addition, the RYG colors themselves can also be altered slightly (make the Red more bluish, the green more yellowish, the yellow more orangish--I think) to be more discriminable by color blind individuals. Online tools exist for this.

@gilgongo
Copy link
Member Author

gilgongo commented May 6, 2020

The trouble is that not all colourblind people are "blind" to the same colours. So if you rely on simply altering the chrominance, the best you can hope for is to make it better for some, but not all colourblind people. See the discussion in #71 . There is also the issue of monitor and ambient light variances too, which mean that colours can be rendered differently in ways we can't control.

@Skeezixes
Copy link

Exactly. I'm not disagreeing. You can make the hues more discriminable to most but not 100% discriminable to all, or even to some. You can make them better, but you can't fix the problem by changing the colors.

@corrados
Copy link
Contributor

corrados commented Oct 7, 2020

Is this still relevant? There were a lot of changes done to the GUI in the last month. Maybe we can close this Issue now.

@gilgongo
Copy link
Member Author

gilgongo commented Oct 7, 2020

I guess we can close it. Accessibility hasn't been a very big issue, so I guess if it gets mentioned again we can reference the ideas here.

@gilgongo gilgongo closed this as completed Oct 7, 2020
@moyesmars
Copy link

For me, it is still not possible to distinguish red/green LEDs. I would very much appreciate if, eg, the current colour would be mentioned in the mouse-over text. E.G.: "The LED indicator is currenty yellow. If it turns to red, you will not have much fun..."

@gilgongo
Copy link
Member Author

gilgongo commented Nov 3, 2020

Mouse over text would require you interact with the UI to discover its state though. Would one of the proposed solutions work not for you?

BTW you could ask why have the lights at all. If all is well then you don't need to look at them. If all is not well then one of the lights will simply show what your ears confirm, but only when you are looking at them. The issue is whether you know what to do in the latter event. But without any history available that's a bit difficult 🔢

@kwindrem
Copy link

kwindrem commented Nov 3, 2020

I think having these indicators is nice to have as it can give you a warning to future issues or to confirm what your ears have detected without opening the Settings pane.

I am not color blind but find short flashes of a color change doesn't always register. I find this with one light level indicators that are green for active signal and turn red for clip.

What about expanding each LED to THREE: 3 lights = Good, 2 lights = Fair, 1 light = Poor?

Maybe having just one quality indicator(three LEDS) that incorporates Buffer and Delay indications would be sufficient.

@gilgongo
Copy link
Member Author

gilgongo commented Nov 4, 2020

Yes, I guess it's nice to have some visual "feedback" of the problems you have with your sound. And of course what to do about it is a separate issue.

What about expanding each LED to THREE: 3 lights = Good, 2 lights = Fair, 1 light = Poor?

Yes that would also solve the issue of using colour alone to convey meaning. Although it would mean a bit more screen space being used. There is also the slight issue of them looking like they might be audio signal indicators perhaps. But one advantage this this approach has over simply labelling the status of the light is that the labels might flicker, so three lights might be clearer in that respect.

@moyesmars
Copy link

I think having these indicators is nice to have as it can give you a warning to future issues or to confirm what your ears have detected without opening the Settings pane.

Agreed. Especially, since I can see when it switches to yellow - but when it switches away from yellow, I don't know whether to red or green...

I am not color blind but find short flashes of a color change doesn't always register. I find this with one light level indicators that are green for active signal and turn red for clip.

What about expanding each LED to THREE: 3 lights = Good, 2 lights = Fair, 1 light = Poor?

Yes, that sounds like a very good idea to me.

@corrados corrados reopened this Nov 7, 2020
@corrados
Copy link
Contributor

corrados commented Nov 7, 2020

What about a simple solution:
CMVVYnKYnH

@moyesmars
Copy link

Thanks for reopening the issue. Yes, simple and suffient IMHO.

@corrados
Copy link
Contributor

corrados commented Nov 7, 2020

@geheimerEichkater From a designer perspective, can you please comment on the new LED designs I created?

@Skeezixes
Copy link

Skeezixes commented Nov 9, 2020 via email

@geheimerEichkater
Copy link
Contributor

Very good topic. I would add two thoughts:

  1. Adjust the colors a tiny bit. I would try to have green be the brightest color, yellow a tad darker/more saturated and red to be the darkest of the three, so brightness offers hierarchy.
  2. Instead of a vertical and horizontal bar which carry no implicit meaning, it'd suggest to set a black dot (or horizontal bar) into the center of the yellow led and a white cross inside the red led.

normal

Deuteranopia

The color values I've applied are:
CC3333 (red)
FFCC00 (yellow)
66FF00 (freen)

@corrados
Copy link
Contributor

Good idea, thanks. I'll try these out. Since for the "Fancy" skin we still have the LED meters which are not distinguishable for color-blind people, I only make these changes for the normal skin (this has bars for the level meters).

@corrados
Copy link
Contributor

Here it is:
ERkoKsSjMs

@corrados
Copy link
Contributor

The new Icons are now applied to the Git master -> closed.

@moyesmars
Copy link

Thanks!

@trebmuh
Copy link
Member

trebmuh commented Nov 11, 2020

That's looking good !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Feature request
Projects
None yet
Development

No branches or pull requests

9 participants