Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase LED luminance in UI? #71

Closed
gilgongo opened this issue Apr 15, 2020 · 18 comments
Closed

Increase LED luminance in UI? #71

gilgongo opened this issue Apr 15, 2020 · 18 comments
Labels
feature request Feature request

Comments

@gilgongo
Copy link
Member

With the addition of the UV meters, the issue of contrast in the UI has become more important. Suggest increasing the luminescence of the colours as below. However, in this mockup the lights are 2D, whereas in the UI they are 3D. This means I can only approximate a good luminance for them.

Here the Red is #FF3300, Green is #66FF33 and Yellow is #FFFF00 while the default is #F2F2F2

image

@corrados
Copy link
Contributor

I'll take care of it.

@trebmuh
Copy link
Member

trebmuh commented Apr 15, 2020

As a color blind person, thanks in advance for that! ❤️

@corrados corrados added the feature request Feature request label Apr 15, 2020
@corrados
Copy link
Contributor

I started with the green LED (see the "Delay" LED on the following screen shot):
grafik
How do you like it?

@trebmuh
Copy link
Member

trebmuh commented Apr 15, 2020

I need to see the whole picture to be able to see if I'm seeing everything correctly. Most of the time, the color differences is the key.

@corrados
Copy link
Contributor

What do you mean by "whole picture"? Do you mean you must see it live in the software when its running?
Here is another screen shot, now the green and red round LEDs are modified:
grafik

@gilgongo
Copy link
Member Author

gilgongo commented Apr 15, 2020

@trebmuh I'm not colour blind, but I think I'm right in saying that we'd never be able to get good contrast between red, green and yellow for everyone on the Delay and Buffers indicator, so that's why I raised #57

The VU meters are a slightly different matter though, since the difference between those colours is only nice to have - the main utility is to see them moving (although it would be nice to have a "clipping" alert of some kind of course)

@trebmuh
Copy link
Member

trebmuh commented Apr 15, 2020

What do you mean by "whole picture"? Do you mean you must see it live in the software when its running?

Usually yes. Or at least a picture with all the final colors.

On the picture above, I've got difficulties to see the differences on the Input L&R horizontal segments which are colored and the other in gray. With a quick look at it, it seems that the 3 last of each columns are colored on green, but if I look closer, the first column could have only 2 greens horizontal segments, and the R colum probably 3 but maybe 4. Note that if I'm looking too long at it, everything gets mixed and I'm loosing ground.

@trebmuh
Copy link
Member

trebmuh commented Apr 15, 2020

@gilgongo of course it is possible to get a good contrast. That's why traffic signals on the street are the colors they are. If not, colorblind people would be car-less or would generate lots of accidents 😉
Your #57 proposition is a good addition by the way and is a good step for blind people with a screen reader to be able to use jamulus.

Edit : I can perfectly see thing on your picture from above:
79324569-b700c100-7f07-11ea-85db-0468770d6969

@corrados
Copy link
Contributor

We may solve #57 by adding a new skin to Jamulus. That new skin should be designed to look very nice but also fulfill all criteria so that color-blind people can distinguish all indicators. See #73

BTW: My screen shot was just work-in-progress. Not the finished version. I did not change the fader LEDs yet in that screen shot.

@trebmuh
Copy link
Member

trebmuh commented Apr 15, 2020

Yes, I saw that #73 . Yes @corrados I did understand that your previous screeenshot wasn't finished yet, but because you asked "How do you like it?", I've answered you the best I can. No rush that being said, just ping me when you're done with the color, and I'll test it and will give you a colordblind feedback on it if you want one.

@corrados
Copy link
Contributor

Here is another example, now the level meter LEDs are also in new color:
grafik

@trebmuh
Copy link
Member

trebmuh commented Apr 15, 2020

It's is very nice for me. The red and green colors are flashy enough for my eyes and I can see the difference. That said, I'm no very sure but there might be a "yellow" light on the Input left column ? If so, it isn't very visible for me. But depending of the meaning of this yellow color, it might not be very important.

@corrados
Copy link
Contributor

Yes, it is. Yellow is critical. It is almost not possible to get it clearer.
I have applied my changes to the Git repo and will use these for the next release. I would close this Issue now and if you tested the new version and still have issues with it, just re-open this Issue again.

@gilgongo
Copy link
Member Author

gilgongo commented Apr 15, 2020

BTW using this simulator, you can see what I mean about the Delay and Buffers indicators if you have deuteranopia for example (which I take it @trebmuh doesn't have?). But this is a minor point as we have the other ticket.

@trebmuh
Copy link
Member

trebmuh commented Apr 15, 2020

From an online test I just did, I've got a deuteranomaly which is red-green color blindness.

emlynmac pushed a commit to emlynmac/jamulus that referenced this issue Apr 15, 2020
@gilgongo
Copy link
Member Author

I've got a deuteranomaly which is red-green color blindness.

Yes, which is different from deuteranopia. This is why I said I think it's not possible to achieve good contrast for everyone because one person might need the contrast between red and yellow, but others might want it between the green and red, for example. We can only optimise for the most common types, of which I think your's is.

@trebmuh
Copy link
Member

trebmuh commented Apr 15, 2020

So I'm lucky about coloring maybe 👼

@trebmuh
Copy link
Member

trebmuh commented Apr 23, 2020

@corrados note that having a clever enough color defaulting system covering most of the case is fine, and having a user defined color scheme option will allow to cover pretty much all scenario.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Feature request
Projects
None yet
Development

No branches or pull requests

3 participants