-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not run CI on documentation changes #2532
Conversation
Peter‘s alternative approach might also work, but this is faster to implement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems safe to do.
Note: README.md is part of Jamulus.pro's DISTFILES, so I guess it's part of make dist
, but we don't run that on CI.
paths-ignore
doesn't work for tags per the docs, so even if we ignore too much, we should be on the safe side for releases.
The duplication is not nice, but I don't see a way around.
Doing trigger-based ignores has the advantage of being able to still run the Action manually if this logic is wrong for some reason.
Maybe I'm the only one caring about |
Just wondering, what about |
bf50209
to
890e277
Compare
Hmm. I've now added other files (except for the ChangeLog since it's somehow related to the release process) |
ChangeLog, README.md and any licence-related files should stay at root level, otherwise discovery proves more difficult. (Particularly auto-discovery.) |
Probably true 😀. Not sure what the gold standard is. |
Sorry, I conflated two things in my comment:
|
I think all the remaining top-level docs need to stay there.
|
I excluded it for the reason that I think the Debian build uses it and it’s related to the release process |
|
890e277
to
13a16f0
Compare
Short description of changes
Stops running the CI if the documentation changes. There is no need of running the CI on non source files. New version of #1921 I think this is a quick fix (and can be update ofc.)
CHANGELOG: Stop running Autobuild if only documentation is updated to avoid wasting computation time.
Context: Fixes an issue?
No. Related to #2282 (comment)
Does this change need documentation? What needs to be documented and how?
No
Status of this Pull Request
Ready for review
What is missing until this pull request can be merged?
Checklist