Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude CONTRIBUTING file from autobuild #2562

Merged
merged 1 commit into from
Apr 17, 2022

Conversation

ann0see
Copy link
Member

@ann0see ann0see commented Mar 28, 2022

Short description of changes

Follow up from #2532 I missed CONTRIBUTING.md

CHANGELOG: SKIP

Context: Fixes an issue?

No. Related to #2561 (comment)

Does this change need documentation? What needs to be documented and how?

No

Status of this Pull Request

Ready to merge

What is missing until this pull request can be merged?

Nothing

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@ann0see ann0see requested a review from hoffie April 7, 2022 21:27
.github/workflows/autobuild.yml Show resolved Hide resolved
@hoffie hoffie added this to the Release 3.9.0 milestone Apr 7, 2022
@ann0see ann0see force-pushed the bug/addCONTRIBUTINGtoCISkip branch from f73bccf to 02691a9 Compare April 7, 2022 21:46
@ann0see
Copy link
Member Author

ann0see commented Apr 7, 2022

Should be squash merged

@ann0see
Copy link
Member Author

ann0see commented Apr 11, 2022

Any other main dev to review this?

@hoffie hoffie requested a review from pljones April 12, 2022 22:27
@ann0see ann0see force-pushed the bug/addCONTRIBUTINGtoCISkip branch from 02691a9 to 22bce78 Compare April 16, 2022 20:41
@ann0see ann0see requested a review from gilgongo April 16, 2022 20:41
@pljones
Copy link
Collaborator

pljones commented Apr 17, 2022

I don't like what's happening with CodeQL on these PRs. It's offputting. Is something wrong with it?

@ann0see ann0see force-pushed the bug/addCONTRIBUTINGtoCISkip branch from 22bce78 to e23c89b Compare April 17, 2022 16:58
@pljones
Copy link
Collaborator

pljones commented Apr 17, 2022

OK, sorted, whatever it was.

@ann0see ann0see merged commit aefdef9 into jamulussoftware:master Apr 17, 2022
@ann0see ann0see deleted the bug/addCONTRIBUTINGtoCISkip branch April 17, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants